Repository navigation
Fix overlay asset paths in web/index.html - #2
Open
AnthoHansen wants to merge 1 commit into
Open
AnthoHansen wants to merge 1 commit into
AnthoHansen wants to merge 1 commit into
Conversation
The overlay files were renamed to loop-overlay.css and loop-overlay.js in 1.40.9, but index.html still loaded lo-overlay.*. Both requests 404, so the overlay (prompts, station dialog, notifications, progress bar) never loads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix overlay asset paths in web/index.html
1.40.9 renamed the overlay files to
web/loop-overlay.cssandweb/loop-overlay.js(andfxmanifest.lualists them under those names), butweb/index.htmlstill loadslo-overlay.cssandlo-overlay.js. Both requests return 404, so the overlay never loads: no interaction prompts, no station dialog (loop:dialogue), noloopnotifications or progress bar.This changes the two paths in
web/index.html. No other files touched.