Skip to content

Documentation fixes - #364

Merged
crandmck merged 6 commits into
loopbackio:gh-pagesfrom
b1az:patch-1
Apr 25, 2017
Merged

crandmck merged 6 commits into
loopbackio:gh-pagesfrom
b1az:patch-1

Conversation

@b1az

@b1az b1az commented Apr 22, 2017

Copy link
Copy Markdown
Contributor

Minor improvements for LB3 docs.

@slnode

slnode commented Apr 22, 2017

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@b1az

b1az commented Apr 22, 2017

Copy link
Copy Markdown
Contributor Author

2a939b8 should address #363.

@crandmck

Copy link
Copy Markdown
Contributor

Thanks @b1az for catching all these!
Only one thing isn't obvious: Why did you remove the video from Managing users?

@b1az

b1az commented Apr 24, 2017

Copy link
Copy Markdown
Contributor Author

@crandmck, I explained the video removal in the commit message:

Its bad audio quality casts a negative light on LoopBack

I'll drop this commit if you want this video to stay.

(I do see the value of having some videos interspersed in the docs, but didn't dare pick a worthy replacement myself.)

@crandmck

Copy link
Copy Markdown
Contributor

OK, sorry I didn't notice the commit message....

I think you're right, the audio is bad. So, I'm OK with removing it.
Thanks!

@crandmck
crandmck merged commit ef0e8ec into loopbackio:gh-pages Apr 25, 2017
@crandmck crandmck mentioned this pull request May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants