Skip to content

Correct/verify data source config containing object or array values #333

Closed

Description

@crandmck

In a recent PR re this statement:

Environment-specific configurations can override the top-level values with string and number values only. You cannot use objects or array values.

@bajtos commented:

This is not true - AFAIK, one can override object values with object values, array values with array values too.

This is mentioned in:

Assuming this is true, then we should remove that statement. Shall we confirm or can just we go on Miroslav's word? ;-)

Activity

  1. changed the title [-]Data source config containing object or array values[/-] [+]Correct/verify data source config containing object or array values[/+] on Mar 22, 2017
  2. self-assigned this
    on Mar 23, 2017
  3. removed this from the Sprint 36 - Asteroid milestone on May 25, 2017
  4. dhmlau commented on May 26, 2017

    @dhmlau
    Member

    @crandmck, I cannot find a definite answer by quickly looking at the code. If @bajtos or @raymondfeng can confirm, that would be great. Otherwise, we might need to try it out to confirm.

    Putting apex in the label so that we won't forget.

  5. added a commit that references this issue on May 26, 2017
  6. crandmck commented on May 26, 2017

    @crandmck
    ContributorAuthor

    OK thanks @dhmlau I went ahead and opened a PR with the doc change. If it's not accurate, then we can just close the PR, or modify as needed.

  7. bajtos commented on May 29, 2017

    @bajtos
    Member

    I have approved the patch, thank you @crandmck for taking care of this!

    I cannot find a definite answer by quickly looking at the code

    See lib/config-loader.js in the 2.x branch for the code that's implementing the merge strategy.

  8. dhmlau commented on May 29, 2017

    @dhmlau
    Member

    I guess it looks like the apex team doesn't need to do anything here? Good to remove the apex label? Thanks.

  9. added a commit that references this issue on May 30, 2017
  10. crandmck commented on May 30, 2017

    @crandmck
    ContributorAuthor

    Thanks @bajtos PR landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions