You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Correct/verify data source config containing object or array values #333
changed the title [-]Data source config containing object or array values[/-][+]Correct/verify data source config containing object or array values[/+]on Mar 22, 2017
@crandmck, I cannot find a definite answer by quickly looking at the code. If @bajtos or @raymondfeng can confirm, that would be great. Otherwise, we might need to try it out to confirm.
Putting apex in the label so that we won't forget.
Activity
[-]Data source config containing object or array values[/-][+]Correct/verify data source config containing object or array values[/+]dhmlau commentedon May 26, 2017
@crandmck, I cannot find a definite answer by quickly looking at the code. If @bajtos or @raymondfeng can confirm, that would be great. Otherwise, we might need to try it out to confirm.
Putting
apexin the label so that we won't forget.Fix for issue #333
crandmck commentedon May 26, 2017
OK thanks @dhmlau I went ahead and opened a PR with the doc change. If it's not accurate, then we can just close the PR, or modify as needed.
bajtos commentedon May 29, 2017
I have approved the patch, thank you @crandmck for taking care of this!
See lib/config-loader.js in the 2.x branch for the code that's implementing the merge strategy.
dhmlau commentedon May 29, 2017
I guess it looks like the apex team doesn't need to do anything here? Good to remove the
apexlabel? Thanks.Fix for issue #333 (#388)
crandmck commentedon May 30, 2017
Thanks @bajtos PR landed.