Repository navigation
Refactor test setup - #30
Merged
Merged
Conversation
superkhau
force-pushed
the
refactor-test-setup
branch
from
February 3, 2017 04:59
a50594d to
85b78de
Compare
Merged
superkhau
force-pushed
the
refactor-test-setup
branch
3 times, most recently
from
February 3, 2017 06:22
540f188 to
50a14b2
Compare
* `black-box/white-box` test dirs split into acceptance/integration/unit * Fix `juggler` tests * Fix `remoting` tests * Fix `loopback` tests * Add smoke integration tests for each package * Combine mocha.opts.* into single shared mocha.opts * Remove `mocha-gherkin` dependency for all relevant packages * Move test descriptions into `feature.md` files for acceptance tests * Use `mocha`'s BDD (default) interface for all tests * Remove unused `crud` tests in `loopback` * Remove global type definitions for `mocha-gherkin` * Remove unused `tsconfig.json` from `testlab` * Add VS Code tasks for running individual test types (ie. `task run loopback acceptance tests, etc`)
superkhau
force-pushed
the
refactor-test-setup
branch
from
February 3, 2017 06:23
50a14b2 to
ffd0189
Compare
Contributor
Author
|
Updated testing wiki to reflect all this too. |
bajtos
reviewed
Feb 3, 2017
| "black-box": "mocha --opts ../../test/mocha.opts.black-box", | ||
| "test": "npm run white-box && npm run black-box", | ||
| "white-box": "mocha --opts ../../test/mocha.opts.white-box" | ||
| "acceptance": "mocha --opts ../../test/mocha.opts test/acceptance", |
Member
There was a problem hiding this comment.
FWIW, it would be great if lerna was able to copy/link /test/mocha.opts to each subdir in packages, so that we don't have to specify --opts explicitly and can simply run mocha test/unit/my-test-file.ts (I do that quite often).
This is out of scope of this pull request though, and most likely requires an enhancement to be contributed to lerna.
Contributor
Author
There was a problem hiding this comment.
@bajtos I was hoping for that too -- couldn't find a way OOB though. ;( I have one hacky idea in my head, but haven't tried it yet because I figure we have bigger 🐟 to fry ATM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black-box/white-boxtest dirs split into acceptance/integration/unitFix
jugglertestsFix
remotingtestsFix
loopbacktestsAdd smoke integration tests for each package
Combine mocha.opts.* into single shared mocha.opts
Remove
mocha-gherkindependency for all relevant packagesMove test descriptions into
feature.mdfiles for acceptance testsUse
mocha's BDD (default) interface for all testsRemove unused
crudtests inloopbackRemove global type definitions for
mocha-gherkinRemove unused
tsconfig.jsonfromtestlabAdd VS Code tasks for running individual test types (ie.
task run loopback acceptance tests, etc)cc @ritch