Skip to content

Refactor test setup - #30

Merged
bajtos merged 1 commit into
masterfrom
refactor-test-setup
Feb 3, 2017
Merged

bajtos merged 1 commit into
masterfrom
refactor-test-setup

Conversation

@superkhau

@superkhau superkhau commented Feb 3, 2017 •

Copy link
Copy Markdown
Contributor
  • black-box/white-box test dirs split into acceptance/integration/unit

  • Fix juggler tests

  • Fix remoting tests

  • Fix loopback tests

  • Add smoke integration tests for each package

  • Combine mocha.opts.* into single shared mocha.opts

  • Remove mocha-gherkin dependency for all relevant packages

  • Move test descriptions into feature.md files for acceptance tests

  • Use mocha's BDD (default) interface for all tests

  • Remove unused crud tests in loopback

  • Remove global type definitions for mocha-gherkin

  • Remove unused tsconfig.json from testlab

  • Add VS Code tasks for running individual test types (ie. task run loopback acceptance tests, etc)

cc @ritch

@superkhau superkhau self-assigned this Feb 3, 2017
@superkhau
superkhau requested a review from bajtos February 3, 2017 04:56
@superkhau
superkhau force-pushed the refactor-test-setup branch from a50594d to 85b78de Compare February 3, 2017 04:59
@superkhau superkhau mentioned this pull request Feb 3, 2017
@superkhau
superkhau force-pushed the refactor-test-setup branch 3 times, most recently from 540f188 to 50a14b2 Compare February 3, 2017 06:22
* `black-box/white-box` test dirs split into acceptance/integration/unit

* Fix `juggler` tests

* Fix `remoting` tests

* Fix `loopback` tests

* Add smoke integration tests for each package

* Combine mocha.opts.* into single shared mocha.opts

* Remove `mocha-gherkin` dependency for all relevant packages

* Move test descriptions into `feature.md` files for acceptance tests

* Use `mocha`'s BDD (default) interface for all tests

* Remove unused `crud` tests in `loopback`

* Remove global type definitions for `mocha-gherkin`

* Remove unused `tsconfig.json` from `testlab`

* Add VS Code tasks for running individual test types (ie. `task run
loopback acceptance tests, etc`)
@superkhau
superkhau force-pushed the refactor-test-setup branch from 50a14b2 to ffd0189 Compare February 3, 2017 06:23
@superkhau

Copy link
Copy Markdown
Contributor Author

Updated testing wiki to reflect all this too.

"black-box": "mocha --opts ../../test/mocha.opts.black-box",
"test": "npm run white-box && npm run black-box",
"white-box": "mocha --opts ../../test/mocha.opts.white-box"
"acceptance": "mocha --opts ../../test/mocha.opts test/acceptance",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, it would be great if lerna was able to copy/link /test/mocha.opts to each subdir in packages, so that we don't have to specify --opts explicitly and can simply run mocha test/unit/my-test-file.ts (I do that quite often).

This is out of scope of this pull request though, and most likely requires an enhancement to be contributed to lerna.

@superkhau superkhau Feb 3, 2017 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bajtos I was hoping for that too -- couldn't find a way OOB though. ;( I have one hacky idea in my head, but haven't tried it yet because I figure we have bigger 🐟 to fry ATM.

@bajtos bajtos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bajtos
bajtos merged commit 8050178 into master Feb 3, 2017
@bajtos
bajtos deleted the refactor-test-setup branch February 3, 2017 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants