Skip to content

Project cleanup - #20

Merged
superkhau merged 1 commit into
masterfrom
refactor/project-cleanup
Jan 27, 2017
Merged

superkhau merged 1 commit into
masterfrom
refactor/project-cleanup

Conversation

@superkhau

@superkhau superkhau commented Jan 27, 2017 •

Copy link
Copy Markdown
Contributor
  • Fix tabbing in loopback/index.js

  • Remove unused gherkin.ts in root test directory

  • Lexical order global type definitions

  • Group test dependencies (expect/sinon) into single global file in root
    test directory

  • Modify both mocha.opts to import single global file instead of
    expect/sinon separately

cc @ritch

@superkhau superkhau self-assigned this Jan 27, 2017
* Fix tabbing in loopback/index.js

* Remove unused gherkin.ts in root test directory

* Lexical order global type definitions

* Group test dependencies (expect/sinon) into single global file in root
  test directory

* Modify both mocha.opts to import single global file instead of
  expect/sinon separately
@superkhau
superkhau force-pushed the refactor/project-cleanup branch from 0d04ef9 to b0a4afc Compare January 27, 2017 03:05
@superkhau
superkhau merged commit f15f4f1 into master Jan 27, 2017
@superkhau
superkhau deleted the refactor/project-cleanup branch January 27, 2017 03:05
Comment thread test/globals.ts

global['expect'] = expect; No newline at end of file
global['expect'] = chai.expect;
global['sinon'] = sinon; No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 ✖️ 💯

Globals are pain to use, didn't we learn that lesson in LoopBack 2.x/3.x yet? See strongloop/loopback#2632.

Please review my proposal on how to fix the problem: #27

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This was just a temp solution. #27 LGTM

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bajtos Yes, it was just a temp solution. +1 for the new testlab package. TY

@bajtos bajtos mentioned this pull request Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants