Repository navigation
Enhance id comparision for updateAttributes - #522
Merged
raymondfeng merged 1 commit intoMar 20, 2015
Merged
Conversation
Member
There was a problem hiding this comment.
Nitpick: The formatting is a bit strange, seeing a closing brace at the start of a line feels weird:
Member
|
Two minor comments, the rest LGTM. |
string/number and MongoDB ObjectID equality are now allowed.
raymondfeng
force-pushed
the
feature/enhance-id-comparison-for-updateAttributes
branch
from
March 20, 2015 18:06
b2c906d to
6a40a8a
Compare
Contributor
Author
|
Issues addressed. |
raymondfeng
added a commit
that referenced
this pull request
Mar 20, 2015
…-for-updateAttributes Enhance id comparision for updateAttributes
raymondfeng
deleted the
feature/enhance-id-comparison-for-updateAttributes
branch
March 20, 2015 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/to @bajtos or @ritch
string/number and MongoDB ObjectID equality are now allowed.