Skip to content

Enhance id comparision for updateAttributes - #522

Merged
raymondfeng merged 1 commit into
masterfrom
feature/enhance-id-comparison-for-updateAttributes
Mar 20, 2015
Merged

raymondfeng merged 1 commit into
masterfrom
feature/enhance-id-comparison-for-updateAttributes

Conversation

@raymondfeng

Copy link
Copy Markdown
Contributor

/to @bajtos or @ritch

string/number and MongoDB ObjectID equality are now allowed.

Comment thread lib/dao.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: The formatting is a bit strange, seeing a closing brace at the start of a line feels weird:

@bajtos

bajtos commented Mar 20, 2015

Copy link
Copy Markdown
Member

Two minor comments, the rest LGTM.

string/number and MongoDB ObjectID equality are now allowed.
@raymondfeng
raymondfeng force-pushed the feature/enhance-id-comparison-for-updateAttributes branch from b2c906d to 6a40a8a Compare March 20, 2015 18:06
@raymondfeng

Copy link
Copy Markdown
Contributor Author

Issues addressed.

raymondfeng added a commit that referenced this pull request Mar 20, 2015
…-for-updateAttributes

Enhance id comparision for updateAttributes
@raymondfeng
raymondfeng merged commit 4ac227b into master Mar 20, 2015
@raymondfeng
raymondfeng deleted the feature/enhance-id-comparison-for-updateAttributes branch March 20, 2015 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants