Repository navigation
Conversation
Loop dropped the amount and units arguments from the remote carb and bolus analytics calls in ServicesManager, which is where remote_window changes the remote delivery signatures. The patch keeps those analytics calls as upstream has them; everything else is unchanged. The old patch is moved to archive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loop changed the remote carb and bolus analytics calls in ServicesManager to no longer pass the amount (#2574), so the nextdev patch stopped applying there. The patch now keeps those calls as upstream has them, and everything else is the same. The old patch is moved to archive.
It applies and reverses cleanly on current next-dev, also together with basal_lock, profiles and negative_insulin in any order. The LoopWorkspace scheme builds with it applied. It does not apply on dev, where remote_window.patch is still used.
To test: