Repository navigation
Conversation
The environment is read from the isAPNSProduction value that Loop uploads to the Nightscout profile, so the manual Production toggle is removed from the Loop APNS settings. The current environment is shown under Debug / Info, the same as for Trio.
Member
Author
|
Why this is safe for people whose Loop doesn't upload LoopFollow only writes the APNS environment when the profile contains
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loop now uploads isAPNSProduction to the Nightscout profile, same as Trio, and LoopFollow already reads it from there. This removes the manual Production toggle from the Loop APNS settings and shows the current environment under Debug / Info instead, like it is for Trio. The hint in the 400 error message about flipping the toggle is removed too.
Requires a Loop build with LoopKit/NightscoutKit#1 and LoopKit/NightscoutService#25.