Repository navigation
Conversation
RoundWhiteDiscKit replaces LibreCRKit. It ships without its lookup tables: they come from a blob on Arweave, and the package pins the blob's digest. - LibreLoopRuntimeTables downloads the blob once (arweave.net, falling back to turbo-gateway.com), saves it in Application Support, and installs it. - Pairing and reconnect install it before anything else. Pairing does so before NFC, so a failed download can't leave an activated sensor that can't be authorized. - Onboarding starts with a download step when the tables aren't installed. Existing users get them on their first reconnect after updating. - Drop the vendored phone_cert_162b.bin; the cert now comes from the tables. - Embed RoundWhiteDiscKit's localization bundle, as was done for LibreCRKit.
Release builds failed to link LibreLoopUI with an undefined RoundWhiteDiscKit.runtimeTablesInstalled getter. With -O and whole-module builds, Swift's default cross-module optimization serializes LibreLoopRuntimeTables.isInstalled into LibreLoop's module, and LibreLoopUICoordinator inlines it -- so LibreLoopUI calls into RoundWhiteDiscKit directly, but only LibreLoop linked the package. Add the package product to LibreLoopUI too. Xcode already builds it as a shared PackageProduct framework, so this links the same single copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit e28c6e0)
Resolve conflicts from the overlapping LoopKit API-surface adaptation
that landed on both branches. Took trio's side for:
- HKUnit.swift: NSLocalizedString-wrapped unit strings
- LibreLoopCGMManager.swift: status comment wording and `_ = isInoperable`
- LibreLoopSampleDetailView.swift / LibreLoopSettingsView.swift: import ordering
- LibreLoopUI/Localizable.xcstrings: kept both new keys
("FreeStyle Libre 3 / 3+" from trio, "Generation" from this branch)
Author
|
Note: I saw the RoundWhiteDiscKit changes land, so I updated to the latest sha for that repo here |
dnzxy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has four different changes bundled into it: