Skip to content

Set default TTS settings and add build script for Windows - #607

Closed
bouchaala-sabri wants to merge 2 commits into
lnreader:mainfrom
bouchaala-sabri:main
Closed

bouchaala-sabri wants to merge 2 commits into
lnreader:mainfrom
bouchaala-sabri:main

Conversation

@bouchaala-sabri

Copy link
Copy Markdown

This PR sets the default TTS language to en-US and the default TTS voice to en-us-x-tpc-network for personal use. The network voice provides better quality than the offline voice. It also adds a new script for building the release on Windows.

Changes made:

  • Set default TTS language to en-US
  • Set default TTS voice to en-us-x-tpc-network
  • Add buildReleaseWin script for Windows users

The changes to the TTS settings were made for personal use, as the network voice provides better quality than the offline voice. The new buildReleaseWin script allows Windows users to easily build the release version of the app.

Set default TTS language and voice for personal use
@nyagami

nyagami commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

But... there're users who dont read LN in English (included me)

@bouchaala-sabri

bouchaala-sabri commented Apr 25, 2023 via email

Copy link
Copy Markdown
Author

@cd0rw0

cd0rw0 commented May 15, 2023

Copy link
Copy Markdown

Hai,

thanks for the this PR. i total agree, offline voice is terrible.
im really looking forward for this.

@nyagami

nyagami commented Aug 17, 2024

Copy link
Copy Markdown
Contributor

Everything you want is available in latest code

@rajarsheechatterjee

Copy link
Copy Markdown
Member

Closing this as the features are now available in the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants