Repository navigation
Set default TTS settings and add build script for Windows - #607
Closed
bouchaala-sabri wants to merge 2 commits into
Closed
bouchaala-sabri wants to merge 2 commits into
bouchaala-sabri wants to merge 2 commits into
Conversation
Set default TTS language and voice for personal use
Contributor
|
But... there're users who dont read LN in English (included me) |
Author
|
of course I'm aware of that, in fact, I can read Arabic and French my self
but as I mentioned in the PR, I made these changes for my own selfish
personal needs. 😄
In all seriousness, I had never developed anything for mobile or Android
before. It took me two days just to figure out how to build the project.
But it was worth it for me because the neural network voices are much
better. In fact, the offline voice was so irritating that I couldn't stand
to listen to it.
I decided to share this in case someone else needed it. And if there's
anyone who can add a setting to choose the language and voices, that would
be great.
I also tried to highlight the sentence being read and make the scroll
follow the current sentence, but I wasn't able to do that.
…On Tue, Apr 25, 2023, 11:42 AM nyagami ***@***.***> wrote:
But... there're users who dont read LN in English (included me)
—
Reply to this email directly, view it on GitHub
<#607 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ6K7YUOA25M6LSAMOD7XTXC6TBTANCNFSM6AAAAAAXJJWTSY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hai, thanks for the this PR. i total agree, offline voice is terrible. |
Contributor
|
Everything you want is available in latest code |
Member
|
Closing this as the features are now available in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the default TTS language to en-US and the default TTS voice to en-us-x-tpc-network for personal use. The network voice provides better quality than the offline voice. It also adds a new script for building the release on Windows.
Changes made:
The changes to the TTS settings were made for personal use, as the network voice provides better quality than the offline voice. The new buildReleaseWin script allows Windows users to easily build the release version of the app.