Repository navigation
Conversation
[Low impact] The change affects results from the plugin live-check workflow. The PR appears safe to merge with a non-blocking improvement to how changed-URL retries are tracked. Findings
SummaryThe live checker now treats observed HTTP 429 responses as inconclusive instead of plugin failures.
One non-blocking edge case remains for retries that change URLs. Local test execution was blocked by the checkout’s missing Reviews (1) · Last reviewed commit: "fix(scripts): treat HTTP 429 rate limits..." · Reviewed by Greptile |
7ui77
force-pushed
the
fix/live-check-http-429
branch
from
November 19, 2026 16:00
6095b9a to
7b6dc4d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
node --test scripts/live-check-plugin.test.js, ESLint, and Prettier)type(scope): description(e.g.feat(<generator>): add new source)Summary
Instead of matching
"429"substrings in localized plugin error messages or auto-retrying requests inside the harness, the checker passively tracks per-stepfetchresponses keyed by(method, url, body)usingAsyncLocalStorage, clears a request key if a retry of that same request succeeds, and reclassifiesFAILsteps that still ended with an unrecovered429.Evidence
Previously, CI live-check runs failed when GitHub Actions runner IPs hit upstream HTTP 429 rate limits across unrelated plugins:
plugins/spanish/novelasmtl.ts:popularNovelsfailed withNovelas MTL: HTTP 429.plugins/spanish/noveltranslations18.ts:parseNovelfailed withNo se pudo acceder a la novela (429).plugins/indonesian/zerokaito.ts:popularNovelsfailed withKaito Novel: HTTP 429 ...plugins/arabic/eightysixar.ts:parseChapterfailed withEightysixAR: HTTP 429.Before:
node --test scripts/live-check-plugin.test.js): 4 pass, 6 fail (exit code1) on unmodifiedmaster.POSTendpoint regression check (different bodies toPOST /admin-ajax.php, e.g.,action=chapters→429,action=meta→200): 13 pass, 1 fail (exit code1) when keyed by URL alone because the secondPOSTcleared the429.After (
node --test scripts/live-check-plugin.test.js): 14 pass, 0 fail in ~3.04s ({ concurrency: 4 }, exit code0) — covers thrown plain/localized429errors acrosspopularNovels,searchNovels,parseNovel, andparseChapter, swallowed429infetchTextandfetchFile, rootHEADprobe429, structured{ status: 429 }errors, retry recovery (GETand sharedPOSTsame-body), sharedPOSTwith distinct bodies preserving429, recovered-then-broken selectors stayingFAIL, late429s from earlier steps not masking later failures, and non-429 errors containing"429"in text stayingFAIL../node_modules/.bin/eslint scripts/live-check-plugin.js scripts/live-check-plugin.test.js --max-warnings 0: passed (0 errors, 0 warnings)../node_modules/.bin/prettier --check scripts/live-check-plugin.js scripts/live-check-plugin.test.js docs/testing.md: passed.Merge Danger
Door: two-way (self-contained in
scripts/anddocs/testing.md; no CI workflows or plugin sources modified).Blast Radius: low (only reclassifies
FAILsteps toINCONCLUSIVEwhen HTTP429was actually observed onfetch/error status/HEADprobe; passing steps and genuine failures remain unchanged).