Skip to content

1. Add Bookkor Korean source plugin - #2844

Open
zephyr1wi-netizen wants to merge 5 commits into
lnreader:masterfrom
zephyr1wi-netizen:master
Open

zephyr1wi-netizen wants to merge 5 commits into
lnreader:masterfrom
zephyr1wi-netizen:master

Conversation

@zephyr1wi-netizen

@zephyr1wi-netizen zephyr1wi-netizen commented Nov 9, 2026 •

Copy link
Copy Markdown

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)
  • Commit messages follow type(scope): description (e.g. feat(<generator>): add new source)

@greptile-apps

greptile-apps Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The PR adds a Bookkor source without changing existing plugin workflows.

Fix the skipped chapter pages before merging; a temporary connection failure currently returns an incomplete list as success.

Findings

  1. P1 Failed pages leave chapter gaps ▶
  2. P2 Bookkor's icon cannot load ▶
  3. P2 Plain chapter text disappears ▶

Summary

Adds the Korean Bookkor source with category browsing, search, novel details, chapter paging, and chapter text extraction.

  • Readers can browse and search Bookkor's novel catalog.
  • Bookkor novels show their details and chapters in reading order.
  • Bookkor chapter pages open as clean reading text.

Reviews (1) · Last reviewed commit: "Delete plugins/korean/bookkor.ts" · Reviewed by Greptile

Comment thread plugins/korean/Bookkor.ts
Comment on lines +228 to +230
this.getHtml(`${novelPath}?page=${n}`)
.then(h => this.parseChapterPage(parseHTML(h)))
.catch(() => [] as RawChapter[]),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Failed pages leave chapter gaps

parseNovel turns failed page requests into empty chapter lists, then moves past those pages without retrying. If page 3 fails while the other pages load, its chapters are skipped. The remaining chapters are renumbered and returned as a successful result. Retry failed pages or let the request fail rather than returning an incomplete list.

Comment thread plugins/korean/Bookkor.ts
class BookkorPlugin implements Plugin.PluginBase {
id = 'bookkor';
name = 'Bookkor (북코)';
icon = 'src/korean/bookkor/icon.png';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Bookkor's icon cannot load

The declared icon has no matching file at public/static/src/korean/bookkor/icon.png. The published plugin entry points to that missing asset, and the playground throws an error when it cannot load it. Add the icon or point icon to an existing asset.

Comment thread plugins/korean/Bookkor.ts
.split('\n')
.map(l => l.trim())
.filter(Boolean)
.map(l => `<p>${l}</p>`)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Plain chapter text disappears

The plain-text fallback inserts decoded text directly into HTML. For example, source text &lt;상태창&gt; becomes <상태창> inside the returned paragraph, so the reader treats it as a tag instead of showing it. Escape each line before wrapping it in <p>.

Suggested change
.map(l => `<p>${l}</p>`)
.map(l => `<p>${l.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;')}</p>`)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant