Repository navigation
Conversation
The FWN entry's noPages skip made popularNovels return [] for pageNo > 1 of the default sort/most-popular listing without even sending a request, while the site serves /sort/most-popular/2 and /3 with distinct novels (verified live 2026-09-22; fixture harness in data/lnreader-freewebnovel-pagination-verify/, not committed). Remove the stale skip for FWN only and bump versionIncrements (2.2.5 -> 2.2.6). Chapter-list pagination is untouched: current master already returns full chapter lists via api/chapterlist.php, and open PR lnreader#2320 covers the chapter-page path it targets. Closes lnreader#2550 (novel-listing half; see PR body for the chapter-list analysis and relation to lnreader#2320). Co-Authored-By: AI agent (pi) <noreply@pi.local>
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Closes the listing-pagination half of #2550 for FreeWebNovel: with the default browse filter (
sort/most-popular), pages after page 1 returned an empty list without any request being sent. Cause: a stale"noPages": ["sort/most-popular"]on theFWN.comentry (added in the #1846 multisrc refactor), which short-circuitspopularNovelsto[]forpageNo > 1on the default filter — while the site itself paginates that list today (verified live: pages 1–3 with distinct novels and correct "- Page N" titles, including the site's own link to/sort/most-popular/2).Change: remove that one
noPagesline (other sources keep theirs) and bumpversionIncrements4 → 5 (plugin 2.2.5 → 2.2.6).template.tsis untouched.No overlap with #2320: that PR changes chapter-list parsing in
template.ts; this one changes onlysources.jsonlisting options. On current master the chapter-list half already resolves through theapi/chapterlist.phpflow from #2322 (a 2404-chapter novel returns all 2404 chapters before and after this change) — the reporter's "page 1 only" symptom matches an older released plugin, not master. Both PRs bumpversionIncrements, so that line may need a manual resolve keeping the higher value.Verification
check:pluginis INCONCLUSIVE here (HTTP 403 — direct runner IPs are Cloudflare-blocked; perdocs/testing.mda site/runner block, not a plugin result). Instead, 11 fresh responses captured through a cleared browser were served to the bundled plugin via a local fetch stub: default-browse pages 2 and 3 go from 0 novels with no request sent to 20 distinct novels each, with page 1, latest/genre/type pages, search, the 2404-chapter novel, and chapter text all unchanged.build:compileandbuild:multisrcpass; lint and format results are identical to clean master.AI-authored change; all claims come from recorded local evidence dated 2026-09-22. No human review.