Repository navigation
Conversation
Member
|
if platform.machine() == "X86_64": It's a typo, it always returns x86_64 afaik, no need for lower(). |
Contributor
Author
|
That's what I thought as well, but it was surprisingly hard to find a definitive answer to that so .lower() was just easier in this case. Removed it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of unnecessary imports that had to go. edit: I reverted most of the cleanup to mintSources.py to make later PRs easier to merge.
While doing that I accidentally noticed that architecture detection in ppa_browser.py was broken at least on my machine due to incorrect capitalization, so I added a .lower() to fix it for all eventualities.
Depends on #134 and #147