Skip to content

Clean up imports and fix ppa_browser arch detection along the way - #148

Closed
gm10 wants to merge 1 commit into
linuxmint:masterfrom
gm10:clean-imports
Closed

gm10 wants to merge 1 commit into
linuxmint:masterfrom
gm10:clean-imports

Conversation

@gm10

@gm10 gm10 commented Jan 23, 2019 •

Copy link
Copy Markdown
Contributor

Lots of unnecessary imports that had to go. edit: I reverted most of the cleanup to mintSources.py to make later PRs easier to merge.

While doing that I accidentally noticed that architecture detection in ppa_browser.py was broken at least on my machine due to incorrect capitalization, so I added a .lower() to fix it for all eventualities.

Depends on #134 and #147

@clefebvre

Copy link
Copy Markdown
Member

if platform.machine() == "X86_64":

It's a typo, it always returns x86_64 afaik, no need for lower().

@gm10

gm10 commented Feb 20, 2019

Copy link
Copy Markdown
Contributor Author

That's what I thought as well, but it was surprisingly hard to find a definitive answer to that so .lower() was just easier in this case. Removed it again.

@gm10 gm10 closed this Apr 9, 2019
@gm10
gm10 deleted the clean-imports branch April 9, 2019 19:55
clefebvre added a commit that referenced this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants