Repository navigation
apt_changelog.py: Fix the PPA source package URL - #80
Open
Amadeus-22 wants to merge 1 commit into
Open
Amadeus-22 wants to merge 1 commit into
Amadeus-22 wants to merge 1 commit into
Conversation
The Launchpad PPA pool URL was a plain string containing an f-string
placeholder, so it was built with a literal '{self.source_prefix()}'
segment and the .dsc lookup always failed, falling back to the last
change only. Use source_prefix() like get_apt_changelog_uri() does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a package from a Launchpad PPA,
apt changelogbuilds the pool URL with:There is no
fprefix, so the URL contains the literal text{self.source_prefix()}instead of the pool prefix (libfforlibfoo). The.dsc/.debian.tar.*lookup then always fails, and the command falls back to the last change only (or exits with 4 when that is missing too), for every PPA package without a local changelog or with--no-local.The fix passes
self.source_prefix()as a format argument, the same prefixget_apt_changelog_uri()already uses for the regular archive.Checked with a script that stubs the network calls and records the URL: