Repository navigation
Conversation
fQwQf
force-pushed
the
sl7-touchpad-buttons
branch
from
September 29, 2026 02:45
5f607f7 to
2d3b675
Compare
fQwQf
changed the title
Button reports and contact tracking have independent lifetimes. Lifting the selected contact currently emits BTN_LEFT=0 even if button reports still indicate a press, interrupting click-and-drag operations. Leave button transitions to button reports, and explicitly release the button when disabling a touchpad to avoid retaining a held click. This also applies to haptic touchpads whose clicks are pressure-driven.
fQwQf
force-pushed
the
sl7-touchpad-buttons
branch
from
September 29, 2026 02:50
2d3b675 to
991f4d1
Compare
fQwQf
marked this pull request as ready for review
September 29, 2026 02:52
|
Tested this on a Surface Laptop Studio 2 (045E:0C46), Arch Linux, It fixes #208 for me. Before the patch, holding the click in the bottom corner and dragging with a second finger was unreliable. An evdev capture of the iptsd virtual touchpad showed why. Whenever a contact lifted while the button was still physically held, iptsd emitted libinput passes this through as a real release followed by a press about 8 ms later. Apps see the drag or selection end and a new one start. With this PR, the button state stays held across contact lifts, and click-drag works as expected. Thanks for the fix! Fixes #208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lifting a tracked touchpad contact emits
BTN_LEFT=0even when button reports still indicate a press, interrupting a click-and-drag operation.Leave button transitions to button reports, and explicitly release the button when disabling a touchpad.
Related: #208.
Validation: