Skip to content

Print path to html report on test failure #21

Closed

Description

@brennantaylor

It would be nice if the path was more easily accessible. If it were printed as part of the test I could click it in the console and open it directly which would be awesome!

Activity

  1. plivesey commented on Aug 31, 2016

    @plivesey
    Contributor

    There is code to do this, but it never gets called:

    - (void)testBundleDidFinish:(NSBundle *)testBundle {
        if (self.failingTestsSnapshotFolders.count > 0) {
            SimpleLog(@"\nSnapshots of failing tests can be found in:\n");
            for (NSString *path in self.failingTestsSnapshotFolders) {
                SimpleLog(@"%@\n", path);
            }
            [self.failingTestsSnapshotFolders removeAllObjects];
        }
    }
    
  2. plivesey commented on Aug 31, 2016

    @plivesey
    Contributor

    I'm taking a look why...

  3. plivesey commented on Aug 31, 2016

    @plivesey
    Contributor

    It looks like testBundleDidFinish: is just never called...but I don't know why this is? I don't presume you have any experience here @brennantaylor?

  4. brennantaylor commented on Sep 2, 2016

    @brennantaylor
    Author

    @plivesey I am not terribly familiar. Maybe try testSuiteDidFinish(_:)?

  5. plivesey commented on Sep 2, 2016

    @plivesey
    Contributor

    Good idea...I'll try that.

  6. plivesey commented on Sep 2, 2016

    @plivesey
    Contributor

    That works, but gets called for every class. Maybe we should print out the path once per file if any of the tests fail for now? At least thats better than what we currently have...

  7. brennantaylor commented on Sep 16, 2016

    @brennantaylor
    Author

    I'd be happy with that.

    In particular appcode buckets the console output by test so that would make me super happy.

  8. plivesey commented on Sep 21, 2016

    @plivesey
    Contributor

    Great. I'll do this with the swift 3 migration work.

  9. plivesey commented on Sep 22, 2016

    @plivesey
    Contributor
  10. plivesey commented on Sep 22, 2016

    @plivesey
    Contributor

    Printing the path on every test suite failure. Opened #28 to track the issue of not being able to print on test bundle finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions