Repository navigation
Prevent duplicate smoke test notifications - #626
Merged
Merged
Conversation
drewoldag
approved these changes
Oct 27, 2026
drewoldag
left a comment
drewoldag
left a comment
Collaborator
There was a problem hiding this comment.
Seems reasonable to me
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send a single Slack / email notification per failing smoke test run:
buildmatrix, so each failing Python version sent a separate notification.webhook-type: webhook-triggerwith an incoming webhook, which was causing the messages to be posted multiple times (for each version in the matrix).The Slack message changes were tested in hats (run #40555254905).
Checklist
lincc-frameworks/python-project-templaterepo and not a downstream one instead.