Skip to content

Handle-initial_routing_sync-requests-from-peers-in-their-Init-messages - #247

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:masterfrom
TheBlueMatt:2018-11-202-redux
Nov 13, 2018
Merged

TheBlueMatt merged 1 commit into
lightningdevkit:masterfrom
TheBlueMatt:2018-11-202-redux

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Collaborator

#202 rebased and cleaned up a bunch.

  • Rejigger the Router API to where it was to avoid the return-value-by-mutable-reference pattern (this also avoids exposing peer_handler-specific internal APIs)
  • Clean up inconsistent spacing/indentation
  • Unify storing of relayable messages with our current should-we-relay checks (fixing DoS in node_announce storage)
  • Add TODO for race in backfilling updates mid-update-for-a-channel

@TheBlueMatt

Copy link
Copy Markdown
Collaborator Author

There are enough changes here I'd love a once-over from @SWvheerden

@SWvheerden SWvheerden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see any problems here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants