Skip to content

Updated provide_latest_holder_commitment_tx. - #2038

Closed
amit-62 wants to merge 2 commits into
lightningdevkit:mainfrom
amit-62:2013-funding-spend
Closed

amit-62 wants to merge 2 commits into
lightningdevkit:mainfrom
amit-62:2013-funding-spend

Conversation

@amit-62

@amit-62 amit-62 commented Feb 16, 2023 •

Copy link
Copy Markdown

provide_latest_holder_commitment_tx to return after the monitor has seen a funding spend confirmed.
fixes #2013

@TheBlueMatt TheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to get some test coverage of this (build a functional test which fetches a local commitment via the unsafe method, then broadcasts it and makes sure that we wont revoke that state as long as we saw it onchain before the new commitment_signed is received).

_ => false,
}).is_some();
if detected_funding_spend {
return Ok(());

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should Err, not Ok. Also, I think we want to still set prev_holder_commitment_signed_tx not drop the old tx? Finally, tabs, not spaces :)

@amit-62 amit-62 Mar 2, 2023 •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @TheBlueMatt Sorry for late reply actually my exam came so I was busy with that. Could you please suggest some resource from which I could took inspiration to write functional test.
Thank you.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheBlueMatt

Copy link
Copy Markdown
Collaborator

Any desire to pick this back up?

@TheBlueMatt

Copy link
Copy Markdown
Collaborator

Closing as abandoned.

@TheBlueMatt TheBlueMatt closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refuse new updates after the ChannelMonitor has seen a funding spend confirmed

3 participants