Repository navigation
Conversation
TheBlueMatt
left a comment
There was a problem hiding this comment.
Would be nice to get some test coverage of this (build a functional test which fetches a local commitment via the unsafe method, then broadcasts it and makes sure that we wont revoke that state as long as we saw it onchain before the new commitment_signed is received).
| _ => false, | ||
| }).is_some(); | ||
| if detected_funding_spend { | ||
| return Ok(()); |
There was a problem hiding this comment.
This should Err, not Ok. Also, I think we want to still set prev_holder_commitment_signed_tx not drop the old tx? Finally, tabs, not spaces :)
There was a problem hiding this comment.
Hello @TheBlueMatt Sorry for late reply actually my exam came so I was busy with that. Could you please suggest some resource from which I could took inspiration to write functional test.
Thank you.
There was a problem hiding this comment.
|
Any desire to pick this back up? |
|
Closing as abandoned. |
provide_latest_holder_commitment_txto return after the monitor has seen a funding spend confirmed.fixes #2013