Skip to content

ChannelManager::force_close_channel does not fail on random channel_id #773

Closed

Description

@sr-gi

ChannelManager::force_close_channel attempts to close any given channel_id, even if the latter is unknown by the manager.

This contrasts with ChannelManager::close_channel, where a errors::APIError::ChannelUnavailable will be raised.

Having the same interface regarding unknown channels by both methods feels like the way to go, so I think force_close_channel should be updated.

Activity

  1. sr-gi commented on Jan 12, 2021

    @sr-gi
    ContributorAuthor

    I can tackle this issue if there's consensus on the update btw.

  2. TheBlueMatt commented on Jan 13, 2021

    @TheBlueMatt
    Collaborator

    I can tackle this issue if there's consensus on the update btw.

    I'd say go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions