You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to convert the few printlns we have to some kind of user-provided logging interface, as well as add a ton of additional logs. I think its fine if we just make it another Arc<trait> that gets passed around everywhere and we call it directly with lines. Would be nice to avoid the format!() overhead when we dont need it, so maybe we can provide build options to turn off debug logging and avoid most of it?
Activity
TheBlueMatt commentedon Jul 20, 2018
Tagged good first issue as at least writing the trait and passing around the Arcs everywhere should be easy, other bits can come later.
ariard commentedon Jul 23, 2018
Just started to working on this, something like a lightweight of crate log, which use compile time filters
TheBlueMatt commentedon Aug 20, 2018
We still need to go through and add a bunch of log traces everywhere, but I'm gonna call this closed by #91 :).
Merge pull request lightningdevkit#54 from TheBlueMatt/main