Skip to content

Logging Interface #54

Closed
Closed

Description

@TheBlueMatt

We need to convert the few printlns we have to some kind of user-provided logging interface, as well as add a ton of additional logs. I think its fine if we just make it another Arc<trait> that gets passed around everywhere and we call it directly with lines. Would be nice to avoid the format!() overhead when we dont need it, so maybe we can provide build options to turn off debug logging and avoid most of it?

Activity

  1. TheBlueMatt commented on Jul 20, 2018

    @TheBlueMatt
    CollaboratorAuthor

    Tagged good first issue as at least writing the trait and passing around the Arcs everywhere should be easy, other bits can come later.

  2. ariard commented on Jul 23, 2018

    @ariard

    Just started to working on this, something like a lightweight of crate log, which use compile time filters

  3. TheBlueMatt commented on Aug 20, 2018

    @TheBlueMatt
    CollaboratorAuthor

    We still need to go through and add a bunch of log traces everywhere, but I'm gonna call this closed by #91 :).

  4. added a commit that references this issue on Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions