Skip to content

AtomicCounter starts at 0x100000001 #3000

Closed

Description

@TheBlueMatt

It should be checking if low == usize::MAX as u64 not low == 0. Should be harmless cause our uses of it shouldn't care about the value, only that its a fresh one each time, but when I fix it some tests fail, so opening this in the hopes someone else does the work.

Activity

  1. added this to the 0.0.124 milestone on Apr 17, 2024
  2. removed this from the 0.0.124 milestone on May 6, 2024
  3. cooltexture1 commented on Aug 13, 2024

    @cooltexture1
    Contributor

    Id like to try this issue! I have a question tho, is there a specific reason that the atomic counter in lightning/src/util/atomic_counter.rs contains two AtomicUsizes, instead of just a single AtomicU64? @TheBlueMatt

  4. TheBlueMatt commented on Aug 13, 2024

    @TheBlueMatt
    CollaboratorAuthor

    Not every platform supports atomic u64s.

  5. added 6 commits that reference this issue on Sep 8, 2024
    c095815
    c5ddd98
    16d014f
    5073de8
    4043801
    2ab133d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions