Skip to content

RUSTSEC-2021-0145: Potential unaligned read #2896

Closed

Description

@github-actions

Potential unaligned read

Details
Status unsound
Package atty
Version 0.2.14
URL softprops/atty#50
Date 2021-07-04

On windows, atty dereferences a potentially unaligned pointer.

In practice however, the pointer won't be unaligned unless a custom global allocator is used.

In particular, the System allocator on windows uses HeapAlloc, which guarantees a large enough alignment.

atty is Unmaintained

A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.

Last release of atty was almost 3 years ago.

Possible Alternative(s)

The below list has not been vetted in any way and may or may not contain alternatives;

See advisory page for additional details.

Activity

  1. tnull commented on Feb 14, 2024

    @tnull
    Contributor

    Nice, the audit CI job works!

    So, @TheBlueMatt, are you happy with bumping criterion or do we add this to the ignore list?

  2. TheBlueMatt commented on Feb 14, 2024

    @TheBlueMatt
    Collaborator

    Nice. I'd really rather we just ignore criterion (can we do that rather than ignoring atty?).

  3. tnull commented on Feb 15, 2024

    @tnull
    Contributor

    Nice. I'd really rather we just ignore criterion (can we do that rather than ignoring atty?).

    Actually we can do neither, we could only ignore this particular advisory (which, IMO, makes a lot of sense and reduces risk down the line).

    FWIW, I still would prefer to just bump criterion, but if you're stuck on 1.63 rustc, I'll open a PR to ignore this to the ignore list, so let me know.

  4. TheBlueMatt commented on Feb 15, 2024

    @TheBlueMatt
    Collaborator

    we could only ignore this particular advisory

    sure, makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions