You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice. I'd really rather we just ignore criterion (can we do that rather than ignoring atty?).
Actually we can do neither, we could only ignore this particular advisory (which, IMO, makes a lot of sense and reduces risk down the line).
FWIW, I still would prefer to just bump criterion, but if you're stuck on 1.63 rustc, I'll open a PR to ignore this to the ignore list, so let me know.
Activity
tnull commentedon Feb 14, 2024
Nice, the audit CI job works!
So, @TheBlueMatt, are you happy with bumping
criterionor do we add this to the ignore list?TheBlueMatt commentedon Feb 14, 2024
Nice. I'd really rather we just ignore criterion (can we do that rather than ignoring atty?).
tnull commentedon Feb 15, 2024
Actually we can do neither, we could only ignore this particular advisory (which, IMO, makes a lot of sense and reduces risk down the line).
FWIW, I still would prefer to just bump criterion, but if you're stuck on 1.63 rustc, I'll open a PR to ignore this to the ignore list, so let me know.
TheBlueMatt commentedon Feb 15, 2024
sure, makes sense to me.