Skip to content

Always honor return value in BP process_events_async #2140

Closed

Description

@tnull

The current default for should_break is true, which is fine, except that we don't override it in the first case of the select, i.e., when ChannelManager::get_persistable_update_future is already available:

define_run_body!(persister,
chain_monitor, chain_monitor.process_pending_events_async(async_event_handler).await,
channel_manager, channel_manager.process_pending_events_async(async_event_handler).await,
gossip_sync, peer_manager, logger, scorer, should_break, {
select_biased! {
_ = channel_manager.get_persistable_update_future().fuse() => true,
exit = sleeper(Duration::from_millis(100)).fuse() => {
should_break = exit;
false
}
}

Activity

  1. changed the title [-]Honor sleeper return value in BP `process_events_async`[/-] [+]Always honor sleeper return value in BP `process_events_async`[/+] on Mar 30, 2023
  2. changed the title [-]Always honor sleeper return value in BP `process_events_async`[/-] [+]Always honor return value in BP `process_events_async`[/+] on Mar 30, 2023
  3. added this to the 0.0.115 milestone on Mar 30, 2023
  4. self-assigned this
    on Mar 30, 2023
  5. added a commit that references this issue on Apr 3, 2023
    66d108c
  6. added 2 commits that reference this issue on Apr 4, 2023
    524b430
    8676c5a
  7. added a commit that references this issue on Jul 24, 2023
    c9face1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions