You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Replace OUR_MAX_HTLCS constant with a config knob #1990
Basically what it says on the tin - add a new config knob and use it in place of OUR_MAX_HTLCS, writing an even TLV if its not 50 to break forwards compat.
The config knob should warn the post-anchor fee-bumping reserves should be scale in consequence (or we do that under the hood). And probably few other warnings.
Sorry for the delay, working on trying to figure out how to properly test this. I'm relatively new to LDK and Lightning development so I could be in over my head here. Here's a code snippet for the "even TLV" change. Also, I added a new field to the Channel struct in channel.rs to replace the referenced constant where possible. Let me know if I am way off!
Sorry for the delay, working on trying to figure out how to properly test this. I'm relatively new to LDK and Lightning development so I could be in over my head here. Here's a code snippet for the "even TLV" change. Also, I added a new field to the Channel struct in channel.rs to replace the referenced constant where possible. Let me know if I am way off!
You can write it as required and read it as an option, which is a bit more succinct, but what you have would work. Matt also mentioned in the top-level comment that it should only be written if it's not 50.
But, this sounds like a fine start, feel free to open a draft PR and you can get feedback there :)
Activity
ariard commentedon Jan 27, 2023
The config knob should warn the post-anchor fee-bumping reserves should be scale in consequence (or we do that under the hood). And probably few other warnings.
swilliamson5 commentedon Mar 6, 2023
I'd like to help! I'll take this as a first issue. I'll need some guidance and I might also post in the Discord for help if needed.
swilliamson5 commentedon Mar 26, 2023
Sorry for the delay, working on trying to figure out how to properly test this. I'm relatively new to LDK and Lightning development so I could be in over my head here. Here's a code snippet for the "even TLV" change. Also, I added a new field to the
Channelstruct inchannel.rsto replace the referenced constant where possible. Let me know if I am way off!valentinewallace commentedon Mar 27, 2023
You can write it as
requiredand read it as anoption, which is a bit more succinct, but what you have would work. Matt also mentioned in the top-level comment that it should only be written if it's not 50.But, this sounds like a fine start, feel free to open a draft PR and you can get feedback there :)