Skip to content

Swap Gossip Message PublicKeys for NodeIds #1973

Closed

Description

@TheBlueMatt

To improve the deserialization time of our network graph and address #960, we swapped the PublicKeys describing node ids directly in the graph with a new NodeId struct in #1107. This improved performance greatly, but missed that we're still deserializing PublicKeys a ton when reading a NetworkGraph - we store the original gossip messages in the graph itself with PublicKeys and have to do a bunch of key checking when reading the graph again.

Replacing the PublicKeys in gossip messages with NodeIds should give us yet again a huge speedup in the time it takes to read our network grpah.

Activity

  1. added this to the 0.0.115 milestone on Jan 21, 2023
  2. alecchendev commented on Feb 6, 2023

    @alecchendev
    Contributor

    I can try and pick this up! I see that the structs UnsignedChannelAnnouncement and UnsignedNodeAnnouncement use PublicKey and are embedded in NetworkGraph. Would this mainly involve changing these structs' PublicKey fields to NodeId and adapting the associated serialization?

  3. TheBlueMatt commented on Feb 6, 2023

    @TheBlueMatt
    CollaboratorAuthor

    Yep, basically just that. We'll need to parse them to PublicKeys when checking signatures (and Err for invalid keys), but that also shouldn't be too complicated (just try to avoid parsing each key more than once in the processing of any given message).

  4. alecchendev commented on Feb 6, 2023

    @alecchendev
    Contributor

    Cool, I'll get started on this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions