Skip to content

Do not claim/reject all inbound HTLCs at once based on preimage/hash #168

Closed

Description

@TheBlueMatt

As of #167 we track HTLCs separately as required by BOLT 2 for privacy. However, we currently reject/accept all to-us HTLCs at once when the user gives us a preimage/no-such-preimage callback. This allows an attacker to (in a really race-y way) query us if we are the intended recipient of a payment that was routed through them by simply sending us a small value HTLC with the same hash as the one they saw. This will likely require an API change, and users may end up needing to do something like tracking the expected value of a payment and only fulfilling HTLCs that match the expected value (to the single-msat level).

Activity

  1. added this to the 0.1 milestone on Sep 11, 2018
  2. TheBlueMatt commented on Sep 11, 2018

    @TheBlueMatt
    CollaboratorAuthor

    Of course tracking value would only work if we also add randomness to the fees we pay ala #158.

  3. TheBlueMatt commented on Sep 19, 2018

    @TheBlueMatt
    CollaboratorAuthor

    I'm gonna unmark this 0.1 cause its not clear that its realistic to build something sensible without moving to something other than simple hash-based HTLCs.

  4. removed this from the 0.1 milestone on Sep 19, 2018
  5. TheBlueMatt commented on May 9, 2021

    @TheBlueMatt
    CollaboratorAuthor

    We've moved on to something "other than simple hash-based HTLCs" with requiring MPP/payment_secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions