You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Further clarify register_tx/register_output distinction in docs #1069
See getlipa/ldk-sample-java#1 (comment) for a concrete suggestion, but it seems there continues to be some confusion from users over the distinction here.
For me the confusion wasn't around the distinction between register_tx and register_output. By providing both the txid and script_pubkey to register_tx made me feel like I might be misunderstanding something about how I needed to be watching for the transaction.
For example, when using BIP157/158 you are able to watch for this transaction by filtering on the script alone. The txid is unnecessary. It might help me add to do the docs something similar to:
'While we provide both the txid and the script_pubkey, depending on how you manage your chain data, you might only use one or both of these pieces of information to monitor for the transaction".
Activity
johncantrell97 commentedon Oct 14, 2021
For me the confusion wasn't around the distinction between register_tx and register_output. By providing both the txid and script_pubkey to register_tx made me feel like I might be misunderstanding something about how I needed to be watching for the transaction.
For example, when using BIP157/158 you are able to watch for this transaction by filtering on the script alone. The txid is unnecessary. It might help me add to do the docs something similar to:
'While we provide both the txid and the script_pubkey, depending on how you manage your chain data, you might only use one or both of these pieces of information to monitor for the transaction".
gabbyprecious commentedon Mar 12, 2022
Hi @ConorOkus is this available to work on?
ConorOkus commentedon Mar 12, 2022
Yes sure @gabbyprecious
tnull commentedon Nov 2, 2022
Will pick this up.
tnull commentedon Dec 9, 2022
Ah, I just saw now that @gabbyprecious indicated in #1395 that she still intends to work on this. Holding off for now.
Provide more color in filter registration methods
Provide more color in filter registration methods