Skip to content

Further clarify register_tx/register_output distinction in docs #1069

Closed

Description

@TheBlueMatt

See getlipa/ldk-sample-java#1 (comment) for a concrete suggestion, but it seems there continues to be some confusion from users over the distinction here.

Activity

  1. added this to the 0.1 milestone on Sep 4, 2021
  2. johncantrell97 commented on Oct 14, 2021

    @johncantrell97
    Contributor

    For me the confusion wasn't around the distinction between register_tx and register_output. By providing both the txid and script_pubkey to register_tx made me feel like I might be misunderstanding something about how I needed to be watching for the transaction.

    For example, when using BIP157/158 you are able to watch for this transaction by filtering on the script alone. The txid is unnecessary. It might help me add to do the docs something similar to:

    'While we provide both the txid and the script_pubkey, depending on how you manage your chain data, you might only use one or both of these pieces of information to monitor for the transaction".

  3. gabbyprecious commented on Mar 12, 2022

    @gabbyprecious

    Hi @ConorOkus is this available to work on?

  4. ConorOkus commented on Mar 12, 2022

    @ConorOkus
  5. self-assigned this
    on Nov 2, 2022
  6. tnull commented on Nov 2, 2022

    @tnull
    Contributor

    Will pick this up.

  7. tnull commented on Dec 9, 2022

    @tnull
    Contributor

    Will pick this up.

    Ah, I just saw now that @gabbyprecious indicated in #1395 that she still intends to work on this. Holding off for now.

  8. linked a pull request that will close this issueadded more clarification #1395on Dec 9, 2022
  9. removed their assignment
    on Dec 9, 2022
  10. added a commit that references this issue on May 5, 2024
    57644f6
  11. added a commit that references this issue on May 29, 2024
    92e8abf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions