Repository navigation
Make CI scripts more homogeneous - #220
Conversation
1b18719 to
193591e
Compare
79a958d to
e9caf8f
Compare
e9caf8f to
6b4bb42
Compare
ef09c6f to
c6f90e1
Compare
Yeah, now went the same route as upstream for the MSRV/1.63 CI: download |
| @@ -0,0 +1,43 @@ | |||
| # Our Esplora-based tests require `electrs` and `bitcoind` | |||
There was a problem hiding this comment.
Can't we do this as part of setup_bitcoind_and_electrsd() in test code?
so that our CI and local tests work consistently and in same manner.
This will avoid another flag.
Moreover, the auto-download feature of bitcoind doesn't work on my mac.
There was a problem hiding this comment.
Can't we do this as part of setup_bitcoind_and_electrsd() in test code?
Electrsd and bitcoind already do this in Rust but pull in quite a bit of annoying unnecessary dev dependencies to do so. Rather than constantly pinning new dependencies (and even risking to mask some actual dependency bump requirements), we can just use CI's curl and be done with it.
so that our CI and local tests work consistently and in same manner.
We leave the auto-download feature as the default behavior, so nothing changes for local testing.
Moreover, the auto-download feature of bitcoind doesn't work on my mac.
I assume this is due to some local anti-virus software or similar, which we probably can't make work in the build scripts. If manual downloads work for you, you can use the newly added download script, or just point BITCOIND_EXE and ELECTRS_EXE env. variables to some preinstalled binaries before running with the no_download cfg flag.
There was a problem hiding this comment.
Ok, I am fine either ways, feel free to continue with current approach.
I was hoping that if we do it ourselves we will just need zip and reqwest and we can use fixed lower versions of those crates.
G8XSU
left a comment
There was a problem hiding this comment.
Feel free to squash fixups.
.. as all of our tests in `functional_tests.rs` are essentially integration tests.
Previously, we used the auto-download feature of the `electrsd`/`bitcoind` crates. While convenient, they unnecessarily introduced a lot of dependecies (`zip`, `zstd`, `time`, etc.) to our test environment which needed pinning for the MSRV of 1.63. Here, we introduce a new `no_download` config flag allowing us to disable this auto-download feature in CI, where we now opt to download the corresponding binaries manually. We keep the default-auto-download as a convenience feature for running tests locally though.
c6f90e1 to
4b8220b
Compare
Squashed without further changes. |
Since we now have a number of different integration tests (CLN, VSS), we move them all to the
testsfolder and align their naming scheme. As most of our Rust tests could also be considered blackbox/integration tests, we also move them fromfunctional_tests.rstotests/integration_tests_rust.rsto clean up our test directory structure.