Repository navigation
Add a builder method to customize where logs are stored - #129
Merged
Merged
Conversation
orbitalturtle
force-pushed
the
set-log-dir
branch
from
June 20, 2023 20:25
e9fdd76 to
cf9a5b6
Compare
tnull
reviewed
Jun 21, 2023
tnull
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for having a look at this!
Collaborator
|
Btw, as you already are touching logging stuff, would you be interested in picking up #126 (as a separate commit)? |
Contributor
Author
|
@tnull Sure thing! I'll take a look at that symlink issue tomorrow |
orbitalturtle
force-pushed
the
set-log-dir
branch
3 times, most recently
from
June 23, 2023 01:08
569e1e2 to
8a587e9
Compare
Contributor
Author
|
@tnull Made those changes |
tnull
reviewed
Jun 23, 2023
orbitalturtle
force-pushed
the
set-log-dir
branch
from
June 27, 2023 19:30
8a587e9 to
aea51c5
Compare
Contributor
Author
|
Oh I messed something up, will fix before you do another pass. |
orbitalturtle
force-pushed
the
set-log-dir
branch
from
June 27, 2023 20:29
aea51c5 to
a226019
Compare
Contributor
Author
|
@tnull ok fixed :) |
orbitalturtle
force-pushed
the
set-log-dir
branch
from
June 28, 2023 17:40
a226019 to
ffe5a0a
Compare
tnull
reviewed
Jul 4, 2023
orbitalturtle
force-pushed
the
set-log-dir
branch
from
July 5, 2023 21:34
ffe5a0a to
3a31209
Compare
Contributor
Author
|
@tnull Great, thanks for the reviews! Made that last little change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small PR to add the option to customize where logs are stored.