Skip to content

Add a builder method to customize where logs are stored - #129

Merged
tnull merged 2 commits into
lightningdevkit:mainfrom
orbitalturtle:set-log-dir
Jul 6, 2023
Merged

tnull merged 2 commits into
lightningdevkit:mainfrom
orbitalturtle:set-log-dir

Conversation

@orbitalturtle

@orbitalturtle orbitalturtle commented Jun 20, 2023 •

Copy link
Copy Markdown
Contributor

Just a small PR to add the option to customize where logs are stored.

@tnull tnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look at this!

Comment thread bindings/ldk_node.udl Resolved
Comment thread src/lib.rs Resolved
Comment thread src/lib.rs Resolved
Comment thread src/builder.rs Resolved
Comment thread src/builder.rs Resolved
@tnull

tnull commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

Btw, as you already are touching logging stuff, would you be interested in picking up #126 (as a separate commit)?

@orbitalturtle

Copy link
Copy Markdown
Contributor Author

@tnull Sure thing! I'll take a look at that symlink issue tomorrow

@orbitalturtle
orbitalturtle force-pushed the set-log-dir branch 3 times, most recently from 569e1e2 to 8a587e9 Compare June 23, 2023 01:08
@orbitalturtle

Copy link
Copy Markdown
Contributor Author

@tnull Made those changes

@orbitalturtle
orbitalturtle requested a review from tnull June 23, 2023 01:30
Comment thread src/builder.rs Resolved
Comment thread src/lib.rs Resolved
Comment thread src/lib.rs Resolved
Comment thread src/logger.rs Resolved
@orbitalturtle

Copy link
Copy Markdown
Contributor Author

Oh I messed something up, will fix before you do another pass.

@orbitalturtle

Copy link
Copy Markdown
Contributor Author

@tnull ok fixed :)

@tnull tnull left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse the delay here!

LGTM, one really minor doc nit. Other than that it's good to go. :)

Comment thread src/lib.rs Resolved
@orbitalturtle

Copy link
Copy Markdown
Contributor Author

@tnull Great, thanks for the reviews! Made that last little change.

@orbitalturtle
orbitalturtle requested a review from tnull July 5, 2023 22:16

@tnull tnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants