Skip to content

Backport 0.7: Widen rusqlite compatibility, use manual downloads - #1225

Merged
tankyleo merged 3 commits into
lightningdevkit:release/0.7from
tnull:2026-11-backport-widen-rusqlite-0.7
Nov 17, 2026
Merged

tankyleo merged 3 commits into
lightningdevkit:release/0.7from
tnull:2026-11-backport-widen-rusqlite-0.7

Conversation

@tnull

@tnull tnull commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Backport branch of #1187 and #1173.

@ldk-reviews-bot

ldk-reviews-bot commented Nov 9, 2026 •

Copy link
Copy Markdown

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Comment thread .github/workflows/rust.yml Resolved
Comment thread tests/rusqlite-compat/README.md Resolved
Fresh builds fail because automatic test binary downloads require
yanked zip releases. The no_download configuration still leaves these
requirements in Cargo's dependency graph.

Use the existing verified download script for local test binaries,
including the VSS jobs, which share the Rust workflow's binary caches.
Document the required environment so fresh builds and local tests work
with the current harness releases.

Upstream fix: https://git.rust-bitcoin.org/rust-bitcoin/corepc/pulls/720

Co-Authored-By: HAL 9000

Backport of a0b9593
Conflicts Resolved in .github/workflows/rust.yml, Cargo.toml,
tests/integration_tests_rust.rs
Requiring rusqlite 0.31 prevents applications from combining LDK Node
with dependencies that need newer SQLite bindings, even when the
persistence APIs remain compatible.

Allow releases from 0.31 through 0.39 while preserving Rust 1.85
support and existing persistence behavior. Exclude 0.40 because its
first two releases require a newer compiler.

Co-Authored-By: HAL 9000

Backport of 0969b15
Conflicts Resolved in Cargo.toml, src/io/sqlite_store/migrations.rs,
src/io/sqlite_store/mod.rs
Root builds remain on rusqlite 0.31 because historical Node releases
are required by upgrade tests. This can conceal incompatibilities
with newer releases allowed by the library.

Test downstream persistence with exact minimum and maximum versions
on Rust 1.85. Keep the fixture independent of the root test graph so
both endpoints are actually exercised.

Co-Authored-By: HAL 9000

Backport of 0d96cbe
@tnull
tnull force-pushed the 2026-11-backport-widen-rusqlite-0.7 branch from 10e2961 to e1b3656 Compare November 17, 2026 09:34
@tnull
tnull requested a review from tankyleo November 17, 2026 09:35
@tankyleo
tankyleo merged commit 230ef0a into lightningdevkit:release/0.7 Nov 17, 2026
8 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants