Repository navigation
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
tankyleo
reviewed
Nov 12, 2026
tankyleo
reviewed
Nov 12, 2026
Fresh builds fail because automatic test binary downloads require yanked zip releases. The no_download configuration still leaves these requirements in Cargo's dependency graph. Use the existing verified download script for local test binaries, including the VSS jobs, which share the Rust workflow's binary caches. Document the required environment so fresh builds and local tests work with the current harness releases. Upstream fix: https://git.rust-bitcoin.org/rust-bitcoin/corepc/pulls/720 Co-Authored-By: HAL 9000 Backport of a0b9593 Conflicts Resolved in .github/workflows/rust.yml, Cargo.toml, tests/integration_tests_rust.rs
Requiring rusqlite 0.31 prevents applications from combining LDK Node with dependencies that need newer SQLite bindings, even when the persistence APIs remain compatible. Allow releases from 0.31 through 0.39 while preserving Rust 1.85 support and existing persistence behavior. Exclude 0.40 because its first two releases require a newer compiler. Co-Authored-By: HAL 9000 Backport of 0969b15 Conflicts Resolved in Cargo.toml, src/io/sqlite_store/migrations.rs, src/io/sqlite_store/mod.rs
Root builds remain on rusqlite 0.31 because historical Node releases are required by upgrade tests. This can conceal incompatibilities with newer releases allowed by the library. Test downstream persistence with exact minimum and maximum versions on Rust 1.85. Keep the fixture independent of the root test graph so both endpoints are actually exercised. Co-Authored-By: HAL 9000 Backport of 0d96cbe
tnull
force-pushed
the
2026-11-backport-widen-rusqlite-0.7
branch
from
November 17, 2026 09:34
10e2961 to
e1b3656
Compare
tankyleo
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport branch of #1187 and #1173.