Skip to content

Bolt11Payment::receive* methods should accept a Bolt11InvoiceDescription instead of a &str #325

Closed

Description

@tvolk131

This is needed for Fedimint lightning gateway to support creating invoices with description hashes

Activity

  1. tnull commented on Jul 15, 2024

    @tnull
    Collaborator

    This is needed for Fedimint lightning gateway to support creating invoices with description hashes

    Unfortunately we can't do this (at least directly), as Bolt11InvoiceDescription wouldn't be exposable via our bindings. I'm also not the biggest fan of complicating the API too much here.

    As other users had similar requirements (i.e., support for description hashes for longer strings), we so far had planned to simply default to a description hash if the provided string was too long (see #312).

    Would this cover your use case, too?

  2. m1sterc001guy commented on Jul 15, 2024

    @m1sterc001guy

    Yes, I believe we can simply always hash it if that's supported

  3. tnull commented on Jul 16, 2024

    @tnull
    Collaborator

    Yes, I believe we can simply always hash it if that's supported

    It would default to hashing whenever the description string length surpasses the maximum size of 639 bytes, and would include the description string otherwise. Just to make sure, this would work for your use case?

  4. joschisan commented on Jul 16, 2024

    @joschisan

    Actually the reasons we even have description hashes was on request of @benthecarman so he would have to answer if this is sufficient for his uses case - iirc it was nostr related.

  5. benthecarman commented on Jul 16, 2024

    @benthecarman
    Contributor

    For lightning addresses it is needed. Would be weird for me that ldk node doesn't expose the description hash, lots of different things use this.

  6. joschisan commented on Jul 16, 2024

    @joschisan

    Could you please elaborate how it is used in lightning addresses?

  7. benthecarman commented on Jul 16, 2024

    @benthecarman
    Contributor

    The lnurl pay spec and nostr zap spec requires that the description hash is a hash of some of the data to make sure you're getting a valid invoice

  8. joschisan commented on Jul 16, 2024

    @joschisan

    If I understand correctly than the hashed metadata in knurl pay is not necessarily longer than 639 bytes, hence the above proposed solution would not work for knurl pay and therefore lightning addresses - correct?

  9. benthecarman commented on Jul 16, 2024

    @benthecarman
    Contributor

    The hash and description are separate fields so you can't really just put the data from one in another

  10. joschisan commented on Jul 16, 2024

    @joschisan

    I think @tnull proposed that ldk would hash a description longer then 639 bytes internally and then put the hash into the description hash field, leaving the description field empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions