You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should add a Config field allowing to set the alias a node would use in its announcement.
For bindings, we'll need to make this a Vec<u8>. We could consider making this an Option<Vec<u8>> and refuse to a) open public channels if it's unset b) startup with public channels if it's unset or doesn't fit in the [u8; 32].
Hi @tnull, I'd like to pick this up if no one is currently assigned to or working on it.
Cool! Sure, go for it!
Note that in contrary to what I wrote above, we may want to expose this as an Option<String> and make sure we sanitize it before setting the alias. This will of course take away some degrees of freedom from our users, but also incentivize not to set some bogus/dangerous aliases that might be parsed wrongly by other network participants.
Moreover, we might want to consider only broadcasting node announcements if both the node alias and valid (public) socket addresses are set.
Hi @tnull, I have a draft PR ready for a cursory look. I am still figuring out how binding generation works but didn't want that to hold up progress especially if you disagree with the direction this is taking. Please share some feedback when you can.
Activity
enigbe commentedon Jul 10, 2024
Hi @tnull, I'd like to pick this up if no one is currently assigned to or working on it.
tnull commentedon Jul 11, 2024
Cool! Sure, go for it!
Note that in contrary to what I wrote above, we may want to expose this as an
Option<String>and make sure we sanitize it before setting the alias. This will of course take away some degrees of freedom from our users, but also incentivize not to set some bogus/dangerous aliases that might be parsed wrongly by other network participants.Moreover, we might want to consider only broadcasting node announcements if both the node alias and valid (public) socket addresses are set.
enigbe commentedon Jul 25, 2024
Hi @tnull, I have a draft PR ready for a cursory look. I am still figuring out how binding generation works but didn't want that to hold up progress especially if you disagree with the direction this is taking. Please share some feedback when you can.
tnull commentedon Oct 7, 2024
Completed in #330.