Skip to content

Expose fees paid for outbound payments #255

Closed

Description

@tnull

For outbound payments, we should expose the fees paid in Event::PaymentSuccessful, and possibly also in PaymentDetails, the latter would go hand-in-hand with the BOLT12 integration as it already will touch the data model there.

Activity

  1. tnull commented on Jun 14, 2024

    @tnull
    CollaboratorAuthor

    Given that we already exposed the paid fees in the PaymentSuccessful event, I'm going back-and-forth whether it's worth complicating the PaymentDirection enum just to include this one field. This would not only be ugly but also would require us to switch it from a 'simple' enum type to an enum interface type in UniFFI bindings, which means we'd need to deal with Arcs etc.

    As the first part is completed, and I'm not convinced about the the second part, I'm closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions