You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For outbound payments, we should expose the fees paid in Event::PaymentSuccessful, and possibly also in PaymentDetails, the latter would go hand-in-hand with the BOLT12 integration as it already will touch the data model there.
Given that we already exposed the paid fees in the PaymentSuccessful event, I'm going back-and-forth whether it's worth complicating the PaymentDirection enum just to include this one field. This would not only be ugly but also would require us to switch it from a 'simple' enum type to an enum interface type in UniFFI bindings, which means we'd need to deal with Arcs etc.
As the first part is completed, and I'm not convinced about the the second part, I'm closing this for now.
Activity
tnull commentedon Jun 14, 2024
Given that we already exposed the paid fees in the
PaymentSuccessfulevent, I'm going back-and-forth whether it's worth complicating thePaymentDirectionenum just to include this one field. This would not only be ugly but also would require us to switch it from a 'simple' enum type to an enum interface type in UniFFI bindings, which means we'd need to deal withArcs etc.As the first part is completed, and I'm not convinced about the the second part, I'm closing this for now.