You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @tnull,
I would like to work on this if no one is assigned to it.
I have outlined a strategy to:
Create a new type, i.e. ElectrumSyncClient
Introduce a set_chain_source/set_tx_sync/set_electrum_client function on NodeBuilder to allow users customize their transaction filters, and default to the EsploraSyncClient in the absence of customization.
Test with one or a few electrum servers. Here is a list of some I have read about and/or used. Given that I don't have extensive knowledge of their adoption in the industry, I would appreciate other suggestions from you to trim/expand the list.
Electrs (via Electrsd already being used in the project)
Hi @tnull, I would like to work on this if no one is assigned to it.
Ah, thanks for showing interest for this! So, this is still blocked on #358, and a follow-up refactoring our syncing logic I intend to open some time this week. After that it should be relatively easy to add Electrum support. Tbh. I might even try to just do it in a commit as part of that refactor PR, we'll see. Happy to have you pick it up though if it doesn't work out though.
I have outlined a strategy to:
Create a new type, i.e. ElectrumSyncClient
Introduce a set_chain_source/set_tx_sync/set_electrum_client function on NodeBuilder to allow users customize their transaction filters, and default to the EsploraSyncClient in the absence of customization.
Test with one or a few electrum servers. Here is a list of some I have read about and/or used. Given that I don't have extensive knowledge of their adoption in the industry, I would appreciate other suggestions from you to trim/expand the list.
Electrs (via Electrsd already being used in the project)
So 1. should already be done in LDK's lightning-transaction-sync (lightningdevkit/rust-lightning#2685), and 2. is part of the syncing (API) refactor mentioned above (at least I hope it will be as easy as I think it is :) ).
Testing (i.e., 3.) sounds good and I'd be very curious to learn if we find any hiccups. I think so far the rust-electrum-client we're building on has been pretty conservative about adding protocol features that aren't widely supported by all server implementations, so I hope we should get good compatibility. But, it would be great to test if this indeed is the case.
I might even try to just do it in a commit as part of that refactor PR, we'll see. Happy to have you pick it up though if it doesn't work out though.
If this is still up when you are done with refactoring the syncing logic, I would be happy to pick it up.
So 1. should already be done in LDK's lightning-transaction-sync
Yeah, I spent some time reading electrum and esplora modules to build an understanding of what's required. It looked like adding a concrete type like was done with EsploraSyncClient, and configuring, was all it would require, given that syncing is already implemented in lightning-transaction-sync.
I would like to review this when it is ready as I build more understanding of the project.
Testing (i.e., 3.) sounds good and I'd be very curious to learn if we find any hiccups. I think so far the rust-electrum-client we're building on has been pretty conservative about adding protocol features that aren't widely supported by all server implementations, so I hope we should get good compatibility. But, it would be great to test if this indeed is the case.
As the release was delayed for a bit anyways, I figured it wouldn't hurt to squeeze in yet another feature. So opened #486 still targeting the 0.5 milestone, hence unslipping this.
Activity
enigbe commentedon Sep 28, 2024
Hi @tnull,
I would like to work on this if no one is assigned to it.
I have outlined a strategy to:
ElectrumSyncClientset_chain_source/set_tx_sync/set_electrum_clientfunction onNodeBuilderto allow users customize their transaction filters, and default to theEsploraSyncClientin the absence of customization.tnull commentedon Sep 30, 2024
Ah, thanks for showing interest for this! So, this is still blocked on #358, and a follow-up refactoring our syncing logic I intend to open some time this week. After that it should be relatively easy to add Electrum support. Tbh. I might even try to just do it in a commit as part of that refactor PR, we'll see. Happy to have you pick it up though if it doesn't work out though.
So 1. should already be done in LDK's
lightning-transaction-sync(lightningdevkit/rust-lightning#2685), and 2. is part of the syncing (API) refactor mentioned above (at least I hope it will be as easy as I think it is :) ).Testing (i.e., 3.) sounds good and I'd be very curious to learn if we find any hiccups. I think so far the
rust-electrum-clientwe're building on has been pretty conservative about adding protocol features that aren't widely supported by all server implementations, so I hope we should get good compatibility. But, it would be great to test if this indeed is the case.enigbe commentedon Oct 1, 2024
If this is still up when you are done with refactoring the syncing logic, I would be happy to pick it up.
Yeah, I spent some time reading
electrumandesploramodules to build an understanding of what's required. It looked like adding a concrete type like was done withEsploraSyncClient, and configuring, was all it would require, given that syncing is already implemented inlightning-transaction-sync.I would like to review this when it is ready as I build more understanding of the project.
ldk-node/src/types.rs
Line 55 in 1a6a2ca
Open to working on this when you are done.
tnull commentedon Oct 17, 2024
This is slipping, but we will land all prerequisites in 0.4. So should do this soon, possibly as a fast-following 0.5.
tnull commentedon Feb 12, 2025
This will unfortunately slip to 0.6.
tnull commentedon Mar 17, 2025
As the release was delayed for a bit anyways, I figured it wouldn't hurt to squeeze in yet another feature. So opened #486 still targeting the 0.5 milestone, hence unslipping this.