[omartelo]

A review of the frontend turned up three things worth fixing and one thing that
only looked broken. Five commits, no user-facing change and no CHANGELOG entry.

The thing that only looked broken: components/ was already organised by
feature and did not need touching. What was actually wrong was narrower —
nothing enforced a format, some logic was written three times over, some markup
five, and lib/ was the one directory in the repo ignoring the repo's own
convention.

7b2766b — biome replaces prettier and eslint

There was no formatter. 80 files wrote import {x}, 54 wrote import { x },
and no single file mixed the two — a clean split down the middle, plus a few
files carrying indentation no tool would produce. eslint was never installed
either, so the five eslint-disable directives in the tree were addressing
nobody.

biome.jsonc encodes the style the code already mostly held (2-space indent,
double quotes, no semicolons) at lineWidth 100 — picked by measuring the
reflow at 80/88/96/100/110 and taking the least-churn width, not by taste.

Rules that were wrong every time they fired are off with the reason inline:
useExhaustiveDependencies (narrow deps are the pattern here — poll signals,
once-per-launch gates, refs read for the latest value) and useOptionalChain
(!x || !x.y states the guard). useImportType is off under components/ui,
which is shadcn CLI output. The a11y group is warn: real findings, but their
fixes are DOM changes.

Everything else the linter flagged is fixed, and none of it changes behaviour —
a missing type annotation, two forEach callbacks returning the callee's value,
a local shadowing Object.prototype.valueOf, two string concatenations. Six
deliberate exceptions carry a biome-ignore naming the reason.

CI gains a pnpm check step beside gofmt and vet.

834d06b — one keyed-store primitive

session-cwd-store, session-agent-store and session-usage-store were the
same store written three times: the same Map<string, Entry>, the same lazy
entryOf, the same per-key subscribe, the same get with an empty fallback,
the same notify loop. Only the value type, the event predicate and — for usage
alone — the definition of "unchanged" ever differed.

createKeyedStore(empty, equal?) is that shape once. The three stores keep
their names, their docs and their exact public surface, and shrink to the wiring
that was unique to them.

The four hooks over them were also one function four times. useKeyedStore
replaces them and takes useGitStatus with it: its empty-path guard — what
keeps a poll from ever starting on "" — generalises to "an empty key
subscribes to nothing".

git-status-store and session-status-store stay as they are on purpose: one
owns a poll cadence with per-entry timers, the other a seen flag and a
cross-project queue. Folding either in means widening the primitive for a single
caller.

9969a68 — extract the markup written more than once

Twelve extractions. Every caller keeps the pixels it had.

Notice (5 copies, two byte-identical) · EmptyScreen (Home / EmptySessions
were the same block down to the gap-4) · SidebarCard (Settings and
PullRequest were the same button class for class) · CloseButton (4 copies) ·
ResizeHandle (2, differing only by the edge usePanelWidth already knows) ·
Stepper (the two Appearance controls; DESIGN.md already named the pattern) ·
IconAction (was HeaderAction, exported from inside diff/FileDiff and
imported across features) · InjectMenu (2) · SearchInput (2) ·
useDiffBulk + CollapseAllAction (2, verbatim) · useInject (3) ·
RESTART_HINT (2).

Side effect worth naming: the a11y warning backlog drops from 36 to 12 without
touching the DOM — the close affordance and the resize handle were reported
four and two times over and are now reported once. The remainder are real and
still warnings; fixing them means adding tab stops and keyboard activation,
which is a behaviour change and belongs in its own PR.

ddb5961 — the React comes out of lib/

Four files under src/lib were not library code. projects.tsx (523 lines) and
settings.tsx (301) are context Providers — the app's state layer — and move to
src/providers/. file-icon.tsx and provider-icons.tsx each export exactly
one component and move to src/components/ under the name they export.

e36ec4e — lib/ groups by domain

src/lib was 59 flat files while src/components has grouped by feature all
along. Five folders now hold what belongs together: session/ (13),
terminal/ (10), git/ (6), pulls/ (6), update/ (4), with 20 cross-cutting
modules at the root (rpc, api-types, app-events, utils, keyed-store,
the card stores, hotkeys, paths, panel width, dnd).

By domain, never by kind: a store and the hook that reads it are one unit, so
git/git-status-store.ts sits beside git/use-git-status.ts rather than in a
stores/ on the other side of the tree. The nine useXxx.ts hooks become
kebab-case, which every other file here already was.

git detects all 67 moves as renames (lowest similarity 86% — the tiny hook
wrappers whose body is mostly imports), so --follow still works.

Test plan

Local gate, green on every commit:

• gofmt -l . clean, go vet ./... clean
• go test ./... — 400 passed in 19 packages
• pnpm check — 0 errors (12 a11y warnings, deliberate; see above)
• pnpm build — tsc typecheck + vite build
• pnpm test — 406 passed in 43 files, up from 398/42 at the branch point;
  the 8 new ones are keyed-store.test.ts, and no existing test changed

No Go file is touched, so no OS seam and no ci:os label.

The frontend suite runs in node with no jsdom, so it cannot catch a render
crash. The extraction commit was therefore hand-verified in task dev across
the surfaces it restructured: both sidebar cards, the dock's tabs / collapse-all
/ full screen / resize, the Pulls screen's three tabs and its empty state, both
Appearance steppers, the inject context menu on a diff and on a file preview,
both search fields, and closing a project tab. The two move commits need no such
pass — tsc resolves every specifier and vite build resolves the whole module
graph, so a bad import is a compile error; the graph and the import order are
otherwise unchanged (organizeImports is deliberately off, nothing was
reordered).

🤖 Generated with Claude Code