Repository navigation
fix(settings): keep the footer item's proportions while dragging - #685
Merged
Merged
Conversation
omartelo
force-pushed
the
fix/footer-drag-overlay-proportion
branch
from
October 8, 2026 20:14
a615e38 to
b0e85e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dragging an item in Settings > Footer showed it wrapped into a taller, narrower block: "PR #123" broke over two lines under the pointer.
Cause
dnd-kit sizes the
DragOverlayto the rect of the chip it lifted, but the overlay's content used its own metrics (px-2.5, asize-4glyph, nowhitespace-nowrap). Wider content in the chip's width wrapped.Fix
The overlay wears the chip's own button metrics (
buttonVariants({ variant: "ghost", size: "xs" })) plus the chip's ring, on abg-popoverfill with a shadow.Verification
pnpm exec biome ci .exit 0,tsc -bclean,footer-layout.test.tsgreen.task dev: the frontend suite does not render components, so the visual result is unverified.