Repository navigation
fix: strip AppImage runtime vars from PTY shell env - #3
Merged
Merged
Conversation
The AppImage runtime injects ARGV0 (the .AppImage's invocation name), APPIMAGE, APPDIR and OWD into the process environment. Start passed the full os.Environ() to the spawned PTY shell, so mise/asdf activation hooks read ARGV0 and mistook the shell for an invalid tool shim, erroring on every terminal open. childEnv filters only those four runtime variables; the rest of the user's login environment (PATH, SHELL, HOME, LANG, ...) is preserved. Applied at the shared spawn point, so both shell and Claude sessions are covered. Outside an AppImage the vars are absent and childEnv is a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a terminal in a
mise/asdf-managed shell errors on every launch:Root cause
The AppImage runtime injects
ARGV0(the.AppImage's invocation name),APPIMAGE,APPDIRandOWDinto the process environment.Startpassed thefull
os.Environ()to the spawned PTY shell (internal/terminal/terminal.go),so
mise/asdfactivation hooks readARGV0and mistook the shell for aninvalid tool shim.
Fix
childEnvfilters only those four AppImage runtime variables before spawningthe shell. The rest of the user's login environment (
PATH,SHELL,HOME,LANG, …) is preserved — the reasonos.Environ()was used (commit2e90529)stays intact. Applied at the shared spawn point, so both shell and Claude
sessions are covered.
No regression
Outside an AppImage (
.deb/.rpm/.pkg/task run) none of these varsare set, so
childEnvis a no-op.Test plan
go vet ./internal/terminal/clean,gofmtappliedchildEnvfilter logic verified (keeps PATH/HOME, drops the 4 AppImage vars)go test -race ./...— local run cannot link WebKitGTK on CachyOSmise activatein the rc, confirm no shim error