Repository navigation
fix: swallow the browser chords Shift was still letting through - #108
Merged
Merged
Conversation
The shifted list was enumerated from the tab and window commands, plus the browsing-data wipe, and stopped there — so Shift became a way past the refusal rather than part of it. Ctrl+P was refused while Ctrl+Shift+P still raised the system print dialog, Ctrl+O while Ctrl+Shift+O still opened the bookmark manager, and Ctrl+Shift+Q exited Chromium outright, which quits lich exactly as Ctrl+W did before #99 stopped it. Shift does not make a chord harmless; it only changes which surface opens. They fired on every screen, a focused terminal included, since xterm only preventDefaults the chords it encodes as a PTY sequence and none of these are one. Ctrl+Shift+B and Ctrl+Shift+A are deliberately still live: an --app window has no bookmarks bar and no tabstrip, so both are no-ops here, confirmed by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#99 taught the
--appwindow to stop behaving like a browser, but the shiftedlist was enumerated from the tab and window commands plus the browsing-data
wipe (
t w n m delete) and stopped there. Shift became a way past the refusalrather than part of it:
pwas refused unshifted, and still raised the systemprint dialog with Shift held. This is the one that turned up in testing.
orefused, bookmark manager still opened.Ctrl+W was already stopped from making.
They fired on every screen, a focused terminal included: xterm only
preventDefaults the chords it encodes as a PTY sequence, and none of theseare one, so the window listener was the only thing that could have claimed
them.
Kept live on purpose: the devtools chords (Ctrl+Shift+I/J/C), reload, F11, and
now-confirmed Ctrl+Shift+B and Ctrl+Shift+A — an
--appwindow has nobookmarks bar and no tabstrip, so both are no-ops here.
Test plan
browser-defaults.test.tscovers the three new keys in the shifted case;the devtools-chords assertion still pins Ctrl+Shift+I/J/C as untouched.
vitest run— 468 passed (45 files).biome checkclean,tsc --noEmitclean.nothing appeared.
not.