Skip to content

feat(pulls): list approved open pull requests from the state menu - #1072

Merged
omartelo merged 1 commit into
mainfrom
feat/pulls-approved-state
Nov 9, 2026
Merged

omartelo merged 1 commit into
mainfrom
feat/pulls-approved-state

Conversation

@omartelo

@omartelo omartelo commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The state menu on the Pulls screen gets Approved, between Open and Closed: the open pull requests whose reviewDecision is APPROVED.
  • It narrows the Open read in pullsStore.list, so there is no extra gh call and no backend or RPC change. The quick filters, their counts and the detail's previous and next all read the narrowed list.
  • It sees the same 50 most recently updated open pull requests the Open list asks for.

Test plan

  • TestPullsStoreApprovedNarrowsTheOpenRead: only approved rows, the Open read left whole, one gh read shared by both states
  • Local gate green on the backend and on native/

@omartelo
omartelo merged commit 3dc4eb1 into main Nov 9, 2026
8 checks passed
@omartelo
omartelo deleted the feat/pulls-approved-state branch November 9, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant