Repository navigation
gesture: raise the double click window to 400 ms - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The double click window in
gesturewas fixed at 200 ms. lich's terminal and browser pane already use 400 ms, GTK's defaultgtk-double-click-time, so a double click 300 ms apart worked there and failed in every Gio widget of the same window (selectable word/line selection, editor, tab bar).This sets
doubleClickDurationto 400 ms, with a comment giving the origin. No distance check, and the desktop's setting is not read.Two cases added to
TestMouseClicks: presses 300 ms apart giveNumClicks2, presses 500 ms apart give 1. The 300 ms case failed before the change (got 1, expected 2).Test plan
go test ./gesture/... ./widget/...in the fork: passnative/withreplace gioui.orgpointing at this branch:go build ./...andgo test ./cmd/lich-native/pass