Repository navigation
Open Nero track-at-once images, and offer .nrg - #39
Open
sunlollyking wants to merge 2 commits into
Open
sunlollyking wants to merge 2 commits into
sunlollyking wants to merge 2 commits into
Conversation
parse_nero() only read the DAOX chunk of a disc-at-once image and rejected images from Nero before 5.5. Track-at-once images have no DAOX; their tracks are in a TINF (before 5.5), ETNF or ETN2 chunk, so they opened with no tracks at all. Accept the older "NERO" footer, and when there's no DAOX build the tracks from those chunks, using the same track modes as DAOX.
MAME's CD code opens .nrg images, but the core didn't list the extension, disc control wouldn't take one, and it wasn't passed to the CD-ROM drive, so frontends never got a Nero image as far as MAME.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nero images (
.nrg) don't load, for two reasons:chdcd_parse_nero()only reads the DAOX chunk of a disc-at-once image, and rejects anything from Nero before 5.5. A track-at-once image has no DAOX: its tracks are in a TINF (before 5.5), ETNF or ETN2 chunk. So it either failed outright or opened with no tracks, and the player showed an open drive..nrganywhere. It's not invalid_extensions,disk_control::is_disc()refused it, andretro_init.cpponly passed chd, iso and cue to-cdrom.The first commit accepts the older
NEROfooter and, when there's no DAOX, builds the tracks from TINF, ETNF or ETN2, using the same track modes as DAOX. The second addsnrgto those three places.My two CD-i Nero images are both a single Mode 2/2336 track, so they also need #38 to read their sectors.
Tested with a small ctypes frontend that boots to the player, presses button 1 on PLAY CD-I and grabs a frame 60 s later, built with #38:
NEROfooter, one TINF track): before, refused; after, its menu.