Repository navigation
Use CMake when building the vendored libgit2. - #261
Conversation
|
I'll see if I can also make cross compilation work again, because this PR breaks it. |
|
I followed these patches and was able to successfully build the library using CMake on Linux. I got a failure attempting to build on OS X 10.8. |
|
@johnbellone Can you post the failure you get? I do all my development on OS X, and have not seen any issue. |
|
Ah it was probably something I screwed up. The build worked fine this time around. |
|
Are we waiting on anything here? I'd be great to not have to maintain my own fork :). |
|
Yeah. I think I won't tackle cross compilation in this PR (so that will be broken, but I guess I'm the only one who cared about that in the first place, anyway). The other is that if this PR gets merged in it's current state, gems will be missing needed files. It should be an easy fix, I'll look into it later today. |
|
@vmg I just pushed some changes to the gemspec to build valid gems and rebased against the latest upstream changes. Can you take a look? |
But we're now printing out warnings, so people will know that Rugged built without CMake does not correctly support some features.
This is especially interesting on Rubinius, where rugged/libgit2 code can actually be executed in different threads concurrently.
|
Merging this now. If you have cmake installed on your system, installing rugged will automatically include https support. We don't yet expose the needed functionality to work with https or ssh remotes that require authentication, but anonymous access for https should work just fine. |
Use CMake when building the vendored libgit2.
Make cross compilation work again.Wait for Always specify -fPIC. libgit2#1834 to be merged into libgit2.See ac8de27.