Skip to content

Bump libgit2 to more recent version - #106

Closed
Quintus wants to merge 5 commits into
libgit2:developmentfrom
Asquera:bump-libgit2
Closed

Quintus wants to merge 5 commits into
libgit2:developmentfrom
Asquera:bump-libgit2

Conversation

@Quintus

@Quintus Quintus commented Oct 9, 2012

Copy link
Copy Markdown

Hi there,

I've bumped the bundled libgit2 to the current HEAD and made some minor fixes for bugs that caused the tests to fail. I'm also working on an implementation of the new checkout and clone features in libgit2 that will require this more recent version rather than the one currently bundled with rugged, but it's not ready yet.

Thanks for considering,
Marvin

Marvin Gülker added 5 commits October 9, 2012 14:37
…sed.

The behaviour of git_reference_lookup has slightly changed upstream;
instead of returning GIT_ENOTFOUND it now returns GIT_ERROR on invalid
reference names. However, the function git_reference_is_valid_name()
can be used to test whether a given reference name is well-formed. This
function now is available from Ruby as Reference.valid? and is used
inside Repository#create_branch.
There have been a few fixes regarding clone operations (namely
regarding cloning of repositories with submodules).
@cgarvis

cgarvis commented Oct 10, 2012

Copy link
Copy Markdown

I'm looking forward to having clone/checkout in rugged

@Quintus

Quintus commented Oct 10, 2012

Copy link
Copy Markdown
Author

Thanks :-). I've updated libgit2 another time, b/c there has been a bugfix regarding submodule handling that affects cloning repos with submodules. I'm almost finished with the clone/checkout stuff so I hope to open another pull request soon.

Marvin

@arrbee

arrbee commented Oct 10, 2012

Copy link
Copy Markdown
Member

Just as a heads up, pull request libgit2/libgit2#968 has a number of additional checkout bug fixes related to submodules and type changes of files, so you may want to keep an eye out for that being merged...

@Quintus

Quintus commented Oct 11, 2012

Copy link
Copy Markdown
Author

Thank you! started watching

Marvin

@Quintus

Quintus commented Nov 19, 2012

Copy link
Copy Markdown
Author

This has been obsoleted by recent commits.

@Quintus Quintus closed this Nov 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants