Repository navigation
feat: support open_url boolean flag to launch browser automatically - #293
Open
HigorMonteiro wants to merge 1 commit into
Open
HigorMonteiro wants to merge 1 commit into
HigorMonteiro wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Problem
The
Server.serve()signature includes anopen_urlparameter, but passingopen_url=Truecurrently does not open the browser. Instead, it only logs an error:Use open_url_delay instead of open_url.For developers and CLI tools using
livereload, requiring an explicit delay in seconds (open_url_delay) when they simply want to open the browser on startup is unintuitive and breaks expectations.💡 Solution
livereload/server.py: Ifopen_url=Trueandopen_url_delay is None, default delay to0so the browser opens automatically upon startup.open_url_delay.livereload/cli.py: Added-b/--open-urlflag.test_open_url_true_opens_browserintests/test_server.py.🧪 Verification
pytest tests/test_server.pypasses.server.serve(..., open_url=True).