Repository navigation
Conversation
The stacked opening's basis evaluated every column claim as a boxed eq_eval over the whole stack point: 141 claims on the 900-leanXMSS leaf, each a product over 27 coordinates, though the claims sit at only 7 distinct low points (a table's columns share its point). A column claim now reaches the stack as StackWeight::Placed (its point, borrowed, and its placement); the ring switch and the Keccak batch's weights stay closures (StackWeight::Other). verify_stacked_opening groups the placed claims by point once, and at the terminal point evaluates eq(point, x_low) per distinct point and only the selector above the window per claim. The basis value is the same field element, so proofs and transcripts are unchanged. Placement::stack_point lost its one caller and is removed; the length check it implied (a claim's point fills its window) is an assert in on_stack. Workload: verifying a 900-leanXMSS leaf (rate 1/2). Products counted. Times on a Ryzen 9 9900X shared at load 10-25, taskset -c 5, interleaved pairs against origin/main; the basis time is instrumented, the fastest of 30 verifies per process (7 pairs); the verify time is the fastest of 100 per process (11 pairs). | metric | main | branch | delta | | ---------------------------- | ----- | ------ | ------------------------------------------------- | | products in the basis | 3,948 | 1,700 | -56.9%, counted | | basis evaluation (us) | ~295 | ~180 | about -39%, B faster in 7/7 (A 294..443, B 180..281) | | whole verify (median ms) | 10.56 | 10.42 | -1.1% per-pair median, -21.7..+0.3%, faster 10/11 | The end-to-end effect is at the edge of the host's noise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The stacked opening's basis evaluated a full
eqover all 27 stack coordinates for each of its 141 column claims, but those claims have only 7 distinct low points. The basis now evaluateseqonce per distinct point, and only the selector bits per claim:eq(point ++ sel, x) = eq(point, x_low) · eq_above(x).For reviewers
Placement::stack_pointlost its only caller and goes. Its length check is now anassert_eq!inon_stack, which panics on the same inputs as before. The review checked that every claim's point length equals its placement's variables by construction, soreplay_uncheckedcannot reach the assert from an announced shape.Checks
lows[at]→lows[0]turnstest_portable_verifierred.Summaryis byte-identical to main.cargo test --release -p verifier -p leanvm_core -p keccak_gkrand clippy: pass.🤖 Generated with Claude Code