Repository navigation
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The WebSocket client returns early for data frames with type
card. When acard.action.triggercallback arrives in such a frame, the registered callback is never invoked and the client sends no reply.Route
CARDframes through the same dispatcher and response handling asEVENTframes. This uses the SDK's existing card callback registration and response serialization.Hermes currently pins
lark-oapi==1.7.5, which has the same early return. See the Hermes maintainer's review for the downstream context.Verification
card.action.triggerpayload into the SDK receive handler. TheEVENTcase passed before the change, while theCARDcase failed with zero callback invocations. Both now invoke the registered handler once and serialize its toast into a successful WebSocket response.python -m pytest -q lark_oapi/ws/tests lark_oapi/event/tests lark_oapi/channel/tests— 767 passed on macOS with Python 3.12.