Skip to content

src: allow custom headers #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lance merged 1 commit into from
Jun 17, 2020
Merged

src: allow custom headers #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transport/http/binary_emitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ async function emit(event: CloudEvent, options: Options, headers: Headers): Prom
const config = {
...options,
method: "POST",
headers: { ...contentType, ...headers },
headers: { ...contentType, ...headers, ...options.headers as Headers},
data: asData(event.data, event.datacontenttype as string)
};
return axios.request(config as AxiosRequestConfig);
Expand Down
11 changes: 11 additions & 0 deletions test-ts/http_emitter_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ describe("HTTP Transport Binding Emitter for CloudEvents", () => {
expect(headers[v1Headers.BINARY_HEADERS.TIME]).to.equal(event.time);
});

it("Sends a binary CloudEvent with Custom Headers", () => {
emitter.send(event, { headers: { customheader: "value" } }).then((response: { data: { [k: string]: string } }) => {
// A binary message will have a ce-id header
expect(response.data.customheader).to.equal("value");
expect(response.data[v1Headers.BINARY_HEADERS.ID]).to.equal(event.id);
expect(response.data[v1Headers.BINARY_HEADERS.SPEC_VERSION]).to.equal(Version.V1);
// A binary message will have a request body for the data
expect(response.data.lunchBreak).to.equal(data.lunchBreak);
}).catch(expect.fail);
});

it("Sends a structured 1.0 CloudEvent if specified", () => {
emitter.send(event, { protocol: Protocol.HTTPStructured })
.then((response: { data: { [k: string]: string | {}, data: { lunchBreak: string } } }) => {
Expand Down