Skip to content

Fix: Fullbright night vision setting improper state handling #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beanbag44 merged 2 commits into from
Sep 28, 2026
Merged

Fix: Fullbright night vision setting improper state handling #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
156862b
Rework Fullbright night vision setting
0xTas Sep 26, 2026
90213fe
Reformat inject annotation onto a single line.
0xTas Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/java/com/lambda/mixin/render/LightmapTextureManagerMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,12 @@ public class LightmapTextureManagerMixin {
@Final
private GpuTexture glTexture;

@Inject(method = "update", at = @At(value = "INVOKE", target = "Lnet/minecraft/util/profiler/Profiler;pop()V", shift = At.Shift.BEFORE))
@Inject(method = "update", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gl/MappableRingBuffer;rotate()V", shift = At.Shift.AFTER))
private void injectUpdate(float tickProgress, CallbackInfo ci) {
if (Fullbright.INSTANCE.isEnabled() || XRay.INSTANCE.isEnabled()) {
RenderSystem.getDevice().createCommandEncoder().clearColorTexture(glTexture, ColorHelper.fullAlpha(ColorHelper.getWhite(1.0f)));
if (XRay.INSTANCE.isEnabled() || (Fullbright.INSTANCE.isEnabled() && !Fullbright.getNightVision())) {
RenderSystem.getDevice()
.createCommandEncoder()
.clearColorTexture(glTexture, ColorHelper.fullAlpha(ColorHelper.getWhite(1.0f)));
}
}

Expand Down
15 changes: 8 additions & 7 deletions src/main/kotlin/com/lambda/module/modules/render/Fullbright.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ package com.lambda.module.modules.render
import com.lambda.config.entries.Setting.Companion.onValueChange
import com.lambda.context.SafeContext
import com.lambda.event.events.TickEvent
import com.lambda.event.listener.SafeListener.Companion.listenOnce
import com.lambda.event.listener.SafeListener.Companion.listen
import com.lambda.module.Module
import com.lambda.module.tag.ModuleTag
import net.minecraft.entity.effect.StatusEffectInstance
Expand All @@ -31,17 +31,18 @@ object Fullbright : Module(
description = "Makes everything brighter",
tag = ModuleTag.RENDER,
) {
private val nightVision by setting("Night Vision", false, description = "Adds the night vision effect client-side")
.onValueChange { _, to -> setNightVision(to) }
@JvmStatic val nightVision by setting("Night Vision", false, description = "Use client-side night vision for better compatibility with shaders")
.onValueChange { _, to -> if (isEnabled) setNightVision(to) }

private val instance = StatusEffectInstance(StatusEffects.NIGHT_VISION, -1, 1, false, false)

init {
listenOnce<TickEvent.Pre> {
if (nightVision && !player.hasStatusEffect(StatusEffects.NIGHT_VISION)) setNightVision(true)
onDisable {
if (nightVision && player.hasStatusEffect(StatusEffects.NIGHT_VISION)) setNightVision(false)
}

// Destroy the listener
true
listen<TickEvent.Pre> {
if (nightVision && !player.hasStatusEffect(StatusEffects.NIGHT_VISION)) setNightVision(true)
}
}

Expand Down